Fix flaky unit tests in resources package #438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting the slices from
GetOutputSteps
andGetInputSteps
in test,to make sure we have a consistent ordering of the slice.
As maps have non-deterministic order in Go, and as we don't sort in
the actual methods (I don't think we need to have a deterministic
slice), the compared slice may not be in the same order. Sorting it by
name fixes that.
Related to #434 (comment)
/cc @bobcatfish @shashwathi
Signed-off-by: Vincent Demeester vdemeest@redhat.com