Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build images for linux/arm (arm32v7) #4331

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Build images for linux/arm (arm32v7) #4331

merged 1 commit into from
Oct 28, 2021

Conversation

imjasonh
Copy link
Member

Fixes #4059

We seemingly stopped building these images because of some issue with git-init, but IMO that's no reason not to build other core components for this platform. It's only supported on a best-effort basis but it seems like there's demand.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Images are built for linux/arm (arm32v7)

@imjasonh imjasonh requested a review from vdemeester October 22, 2021 19:46
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 22, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2021
@imjasonh
Copy link
Member Author

/test check-pr-has-kind-label

afrittoli
afrittoli reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jason!
Before we merge this, shall we add some documentation about this issue?
Which raises the question, where shall we document this?
The installation.md might be a good place, but perhaps we could add a section about features of the releases, like architectures / OSes included.

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2021
@imjasonh
Copy link
Member Author

Thanks Jason! Before we merge this, shall we add some documentation about this issue? Which raises the question, where shall we document this? The installation.md might be a good place, but perhaps we could add a section about features of the releases, like architectures / OSes included.

Added docs, PTAL

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2021
SaschaSchwarze0
SaschaSchwarze0 reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @imjasonh, I think arm64 should also be listed under Platform Support.

@imjasonh
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@ghost
Copy link

ghost commented Oct 28, 2021

Cheers!

/lgtm

@tekton-robot tekton-robot assigned ghost Oct 28, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@tekton-robot tekton-robot merged commit 85d47c2 into tektoncd:main Oct 28, 2021
@bobcatfish bobcatfish mentioned this pull request Nov 1, 2021
Closed
@imjasonh imjasonh mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 left review comments

@vdemeester vdemeester vdemeester approved these changes

@jerop jerop Awaiting requested review from jerop

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No more arm32v7 images available after v0.21.0
5 participants
@imjasonh @tekton-robot @vdemeester @afrittoli @SaschaSchwarze0