Small entrypoint unit test fixes prior to 0.27 release #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
post_writer_test.go previously used os.ReadFile which was only introduced in Go 1.16. This commit replaces os.ReadFile with ioutil.ReadFile for compatibility with older Go versions. entrypointer_test.go previously wrote a termination file to the developer's git repo which meant it showed up running `git status`. This commit creates a random TempFile for termination paths which are then cleaned up at the end of the test.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
post_writer_test.go previously used os.ReadFile which was only introduced in Go
1.16. This commit replaces os.ReadFile with ioutil.ReadFile for compatibility
with older Go versions.
entrypointer_test.go previously wrote a termination file to the developer's git
repo which meant it showed up running
git status. This commit creates arandom TempFile for termination paths which are then cleaned up at the end of
the test.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes