Replace snooze with NewRequeueKey #4131
Conversation
|
The following is the coverage report on the affected files.
|
dac08b4 to
dbbb274
Compare
|
The following is the coverage report on the affected files.
|
dbbb274 to
af4622e
Compare
|
The following is the coverage report on the affected files.
|
|
/retest I think this is a flake, let's see |
|
@ScrapCodes Probably not the best place to discuss. Is there an issue or some place that I should read through for more context about what you are trying to do? If you link it here or DM it to me on slack, I can try to weigh in. In general, I see the enqueue functions as fairly low-level mechanisms, so we should probably only reach around the controller abstractions we have in place fairly intentionally, and consider whether it's possible to do the same within the abstraction or extend the abstraction for the use case you have in mind. |
|
/easycla |
Can I schedule some function, without creating a goroutine inside a reconciler?e.g. if I use time.AfterFunc it creates a goroutine. A reconciler may maintain its thread pool, in order to schedule something e.g. after 1 min check if there is update otherwise timeout. Do we have this from knative? In my PR, I am trying to timeout a run (i.e. it does not support retries) if the custom task controller does not respond within a short timeout. This can be achieved by scheduling a reconciling event for that PipelineRun and then checking if the last update time has elapsed the timeout duration. |
af4622e to
011ebc8
Compare
|
I've rebased this and it should be RFAL. @CI-Gods 👇 |
|
The following is the coverage report on the affected files.
|
|
Hmm, let's try another 🐐 . This looks like a flake. /retest |
|
I'm seeing this in the detailed logs, which seems very unlikely to be related to my change: /retest |
|
Weird, this one's reporting |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
|
@mattmoor btw this is the PR I was referring to when I started that whole thread about asking reviewers check look at the checklist requirements b/c I didnt feel the commit message had enough context - In this specific case looking at the PR it's hard for me to understand what NewRequeueKey is and why it replaces snooze (i think id have to go digging into the knative/pkg code to figure that out?) |
|
Yeah, this is a bit better: knative/pkg#2201 |
|
Ah that's great, thanks for the extra conext @mattmoor |
Changes
Adopt the
NewRequeueKeyto replace thesnoozefunctions./kind cleanup
WIP until #4129 lands
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes