Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WhenExpressions to variable substitution documentation #4091

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

jerop
Copy link
Member

@jerop jerop commented Jul 13, 2021

Changes

We have a table that documents all fields that accept variable
substitution, and the fields in WhenExpressions need to be added.

This change documents that input and values fields in the when
field accept variable substitution.

/kind documentation

Thanks to @bobcatfish for the catch! 😀

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

We have a table that documents all fields that accept variable
substitution, and the fields in WhenExpressions need to be added.

This change documents that `input` and `values` fields in the `when`
field accept variable substitution.
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 13, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2021
Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jerop

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@ghost
Copy link

ghost commented Jul 13, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Jul 13, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@jerop
Copy link
Member Author

jerop commented Jul 13, 2021

/test tekton-pipeline-unit-tests

@tekton-robot tekton-robot merged commit 42ca2bc into tektoncd:main Jul 13, 2021
@jerop jerop deleted the when-variables branch June 11, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants