Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue link to comment in controller yaml #4088

Merged
merged 1 commit into from Jul 12, 2021
Merged

Add issue link to comment in controller yaml #4088

merged 1 commit into from Jul 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 12, 2021

Changes

In commit 49a7fa2 we added
a workaround for an issue that can cause the tekton controller
to be delayed launching taskruns for the first time.

This commit updates the comment on the workaround to include
an issue link with more information about the reason for the
workaround.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE

In commit 49a7fa2 we added
a workaround for an issue that can cause the tekton controller
to be delayed launching taskruns for the first time.

This commit updates the comment on the workaround to include
an issue link with more information about the reason for the
workaround.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/documentation Categorizes issue or PR as related to documentation. labels Jul 12, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2021
@pritidesai
Copy link
Member

thanks @sbwsg
/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2021
@tekton-robot tekton-robot merged commit 7e4189d into tektoncd:main Jul 12, 2021
@ghost ghost added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Jul 13, 2021
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants