Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way we run e2e tests with feature gates in pipelines #3930

Merged
merged 1 commit into from May 17, 2021
Merged

Change the way we run e2e tests with feature gates in pipelines #3930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,14 @@ function run_e2e() {
go_test_e2e -tags=examples -timeout=20m ./test/ || failed=1
}

set_feature_gate "stable"
run_e2e
if [ "$PIPELINE_FEATURE_GATE" == "" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: We could also do:

set_feature_gate "${PIPELINE_FEATURE_GATE:-stable}"
run_e2e

But this works too.

set_feature_gate "stable"
run_e2e
else
set_feature_gate "$PIPELINE_FEATURE_GATE"
run_e2e
fi

set_feature_gate "alpha"
run_e2e

(( failed )) && fail_test
success