Change to avoid error when service account has empty secret name #3795
Conversation
|
Hi @cqbqdd11519. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/pod/creds_init.go
Outdated
| @@ -73,6 +73,9 @@ func credsInit(ctx context.Context, serviceAccountName, namespace string, kubecl | |||
| var volumes []corev1.Volume | |||
| args := []string{} | |||
| for _, secretEntry := range sa.Secrets { | |||
| if len(secretEntry.Name) == 0 { | |||
There was a problem hiding this comment.
Suggest if secretEntry.Name == "" { to match line 61.
bd87efa to
50a6c9f
Compare
|
/ok-to-test |
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-build-tests |
Avoid pod-generation error when a service account has following empty
named secret field
secrets:
- {}
50a6c9f to
886895a
Compare
|
The following is the coverage report on the affected files.
|
|
/remove-kind bug |
|
/kind bug |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm thank you @cqbqdd11519 for your contribution 🙏 I have added release note as this PR is fixing an existing bug. @sbwsg please feel free to update the release note if needed. |
Changes
Avoid pod-generation error when a service account has following empty named secret field
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes docs (if user facing)Release notes block has been filled in or deleted (only if no user facing changes)See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes