-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine the comment for git init base image #3791
Conversation
Hi @zhangtbj. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
.ko.yaml
Outdated
@@ -1,7 +1,6 @@ | |||
defaultBaseImage: gcr.io/distroless/static:nonroot | |||
baseImageOverrides: | |||
# These base images run as root, which is needed for how they handle SSH credentials. | |||
# They are produced from ./images/Dockerfile | |||
# git-init resource supports to run as non-root user with UID 65532 that can clone repos without requiring root permissions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest git-init uses a base image that supports running either as root or as user nonroot with UID 65532
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion @sbwsg !
Update by using this better one.
Good catch, thanks for fixing that! |
44e22a1
to
4bb0f1d
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
After the PR is merged: #3727
The
git-init
init image can be executed by as non-root user.The original comment
These base images run as root, xxx
is not valid and will make user confuse.Provide a PR to refine the comment for the
git-init
image/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes