Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to PipelineRunSpecStatusPending #3723

Merged
merged 1 commit into from Jan 27, 2021
Merged

Add comment to PipelineRunSpecStatusPending #3723

merged 1 commit into from Jan 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2021

Changes

Following up on my issue comment here: #3522 (comment)

Prior to this commit we didn't have a comment attached to the PipelinerunSpecStatusPending
status string.

This commit adds a comment to the status string.

Submitter Checklist

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

Prior to this commit we didn't have a comment attached to the PipelinerunSpecStatusPending
status string.

This commit adds a comment to the status string.
@ghost ghost added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 27, 2021
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 27, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
@jerop
Copy link
Member

jerop commented Jan 27, 2021

/test check-pr-has-kind-label

@tekton-robot tekton-robot merged commit 21f3ff0 into tektoncd:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants