Fix TestPipelineLevelFinally_OneDAGTaskFailed test to avoid false negative error

[barthy1]

Changes

For TestPipelineLevelFinally_OneDAGTaskFailed_InvalidTaskResult_Failure test list of skipped tasks is checked. In case if order of actual skipped tasks is different than expected, test may fail despite equality between actual and expected skipped tasks.

    pipelinefinally_test.go:288: Expected four skipped tasks, dag task with condition failure dagtask3, dag task with when expression,two final tasks with missing result reference finaltaskconsumingdagtask1 and finaltaskconsumingdagtask4 in SkippedTasks. Diff: (-want, +got):   []v1beta1.SkippedTask{
          	{Name: "dagtask3"},
          	{Name: "dagtask4", WhenExpressions: {{Input: "foo", Operator: "notin", Values: {"foo"}}}},
          	{
        - 		Name:            "finaltaskconsumingdagtask4",
        + 		Name:            "finaltaskconsumingdagtask1",
          		WhenExpressions: nil,
          	},
          	{
        - 		Name:            "finaltaskconsumingdagtask1",
        + 		Name:            "finaltaskconsumingdagtask4",
          		WhenExpressions: nil,
          	},
          }
...
--- FAIL: TestPipelineLevelFinally_OneDAGTaskFailed_InvalidTaskResult_Failure (29.51s)

Sort of actual skipped tasks based on their names will fix this problem.

/kind failing-test

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

[barthy1]

/test check-pr-has-kind-label

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment