Correct workspace doc on behaviour of mountPath #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we documented that if a workspace's mountPath was relative then Pipelines would prepend "/workspace/" to it. This behaviour has never actually worked that way. Pipelines passes the literal mountPath value directly to the volumeMount's mountPath, without any other processing. It's then up to the platform to decide what to do with it. This commit fixes the workspaces doc to remove the incorrect description.
vdemeester
approved these changes
Jan 26, 2021
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jerop
approved these changes
Jan 26, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
awesome thanks /lgtm |
|
/test pull-tekton-pipeline-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3716
Changes
Prior to this commit we documented that if a workspace's mountPath was
relative then Pipelines would prepend "/workspace/" to it. This behaviour
has never actually worked that way. Pipelines passes the literal mountPath
value directly to the volumeMount's mountPath, without any other
processing. It's then up to the platform to decide what to do with it.
This commit fixes the workspaces doc to remove the incorrect description.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes