release: publish only on a given list of platforms 💻 #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
/kind misc |
|
/area release |
|
/lgtm 👌 |
|
@vdemeester do you think it makes sense to have list of platforms configurable also for base image build and manage them in one place on release pipeline level? |
Very good point, I'll update 😉 |
This update the publish task to build and publish images for a given set of platforms instead of all supported by base images. This allows to be a bit more explicit on which architecture we build on (not necessarly supporting them yet). One of the reason for this is to not build an incomplete set of images for a given platform/architecture if a base image doesn't support it (e.g. linux/arm). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
d856b35 to
c082f1a
Compare
|
/lgtm Looking Good! 🤙🏽 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This update the publish task to build and publish images for a given
set of platforms instead of all supported by base images. This allows
to be a bit more explicit on which architecture we build on (not
necessarly supporting them yet).
One of the reason for this is to not build an incomplete set of images
for a given platform/architecture if a base image doesn't support
it (e.g. linux/arm).
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/cc @afrittoli @bobcatfish @barthy1
This replaces #3664 and relates to #3647, without fixing it as we won't publish anything for
linux/armanymore.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes