Adding power (ppc64le) architecture image mappings #3630

bahetiamit · 2020-12-11T14:36:00Z

Changes

Adds ppc64le architecture image mappings
Excludes some of the test cases for ppc64le

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices
Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

tekton-robot · 2020-12-11T14:36:15Z

Hi @bahetiamit. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

test/multiarch_utils.go

ghost · 2020-12-11T16:18:52Z

/ok-to-test

tekton-robot · 2020-12-11T16:21:45Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

tekton-robot · 2020-12-14T05:53:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

vdemeester · 2020-12-14T09:23:07Z

@sbwsg anyway to look at #3550 too 🐼 (might affect this)

barthy1 · 2020-12-14T10:34:03Z

test/multiarch_utils.go

@@ -106,14 +118,44 @@ func imageNamesMapping() map[string]string {
 			"stedolan/jq":                           "ibmcom/jq-s390x:latest",
 			"gcr.io/kaniko-project/executor:v1.3.0": getTestImage(kanikoImage),
 		}
+	case "ppc64le":
+		return map[string]string{
+			"gcr.io/tekton-releases/dogfooding/alpine-git-nonroot:mario": "gcr.io/tekton-releases/dogfooding/alpine-git-nonroot:latest",


This image is not used in tests any more

Thanks for pointing out. Removed this unused mapping.

barthy1 · 2020-12-14T10:34:11Z

test/multiarch_utils.go

+			"mikefarah/yq":                          "danielxlee/yq:2.4.0",
+			"stedolan/jq":                           "ibmcom/jq-ppc64le:latest",
+			"gcr.io/kaniko-project/executor:v1.3.0": getTestImage(kanikoImage),
+			"quay.io/rhpipeline/skopeo:alpine":      "ibmcom/skopeo-ppc64le",


This image is not used in tests any more

tekton-robot · 2020-12-14T12:10:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

bahetiamit · 2020-12-15T06:30:50Z

/test pull-tekton-pipeline-integration-tests

tekton-robot · 2020-12-16T06:41:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

tekton-robot · 2020-12-16T08:57:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2021-01-04T08:33:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

bahetiamit · 2021-01-04T14:26:23Z

/test pull-tekton-pipeline-integration-tests

bahetiamit · 2021-01-05T14:11:02Z

Is there any issue with build infra? pull-tekton-pipeline-integration-tests seems to be failing.

vdemeester · 2021-01-05T14:15:04Z

@bahetiamit hum, this is happening on all PRs it seems, something changed somewhere 😓

bahetiamit · 2021-01-08T11:37:20Z

/test pull-tekton-pipeline-integration-tests

bahetiamit · 2021-01-13T06:59:17Z

@afrittoli Please see if you can find time to review this

tekton-robot · 2021-01-28T13:47:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

bahetiamit · 2021-01-28T13:53:44Z

/test pull-tekton-pipeline-build-tests

bahetiamit · 2021-01-29T06:31:56Z

/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests

tekton-robot · 2021-01-29T09:47:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

bahetiamit · 2021-02-01T06:28:23Z

@vdemeester I am not sure why pull-tekton-pipeline-build-tests is failing. Are you aware of any issue with build infra?

vdemeester · 2021-02-01T08:48:02Z

@bahetiamit looking at the log

-------------------------------------------
---- Checking go code style with gofmt ----
-------------------------------------------
diff -u test/multiarch_utils.go.orig test/multiarch_utils.go
--- test/multiarch_utils.go.orig	2021-01-29 09:45:57.785742280 +0000
+++ test/multiarch_utils.go	2021-01-29 09:45:57.785742280 +0000
@@ -74,20 +74,20 @@
 		}
 	case "ppc64le":
 		return map[int]string{
-			busyboxImage:  "busybox@sha256:4f47c01fa91355af2865ac10fef5bf6ec9c7f42ad2321377c21e844427972977",
-			registryImage: "ppc64le/registry:2",
-			kubectlImage:  "ibmcom/kubectl:v1.13.9",
-			helmImage:     "ibmcom/helm-ppc64le:latest",
-			kanikoImage:   "ibmcom/kaniko-project-executor-ppc64le:v0.17.1",
+			busyboxImage:   "busybox@sha256:4f47c01fa91355af2865ac10fef5bf6ec9c7f42ad2321377c21e844427972977",
+			registryImage:  "ppc64le/registry:2",
+			kubectlImage:   "ibmcom/kubectl:v1.13.9",
+			helmImage:      "ibmcom/helm-ppc64le:latest",
+			kanikoImage:    "ibmcom/kaniko-project-executor-ppc64le:v0.17.1",
 			dockerizeImage: "ibmcom/dockerize-ppc64le",
 		}
 	default:
 		return map[int]string{
-			busyboxImage:  "busybox@sha256:895ab622e92e18d6b461d671081757af7dbaa3b00e3e28e12505af7817f73649",
-			registryImage: "registry",
-			kubectlImage:  "lachlanevenson/k8s-kubectl",
-			helmImage:     "alpine/helm:3.1.2",
-			kanikoImage:   "gcr.io/kaniko-project/executor:v1.3.0",
+			busyboxImage:   "busybox@sha256:895ab622e92e18d6b461d671081757af7dbaa3b00e3e28e12505af7817f73649",
+			registryImage:  "registry",
+			kubectlImage:   "lachlanevenson/k8s-kubectl",
+			helmImage:      "alpine/helm:3.1.2",
+			kanikoImage:    "gcr.io/kaniko-project/executor:v1.3.0",
 			dockerizeImage: "jwilder/dockerize",
 		}
 	}

I think you need to do a gofmt -s -w on that file.

tekton-robot · 2021-02-01T12:55:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
test/multiarch_utils.go	63.6%	56.0%	-7.6

bahetiamit · 2021-02-01T13:33:27Z

Thanks @vdemeester. All checks are green now.

imjasonh

/lgtm

imjasonh · 2021-02-18T11:21:03Z

test/multiarch_utils.go

+			registryImage:  "ppc64le/registry:2",
+			kubectlImage:   "ibmcom/kubectl:v1.13.9",
+			helmImage:      "ibmcom/helm-ppc64le:latest",
+			kanikoImage:    "ibmcom/kaniko-project-executor-ppc64le:v0.17.1",


Is there any possibility of having ppc64le support in the official kaniko images? They recently started publishing multiarch images, so it shouldn't be too difficult to add unless I'm missing something

tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 11, 2020

tekton-robot requested review from afrittoli and vdemeester December 11, 2020 14:36

tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2020

ghost reviewed Dec 11, 2020

View reviewed changes

test/multiarch_utils.go Outdated Show resolved Hide resolved

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2020

bahetiamit force-pushed the power branch from 9bb6b49 to e9ac6ea Compare December 14, 2020 05:50

barthy1 reviewed Dec 14, 2020

View reviewed changes

bahetiamit force-pushed the power branch from e9ac6ea to fb3aedf Compare December 14, 2020 12:07

bahetiamit force-pushed the power branch from fb3aedf to 895dcfc Compare December 16, 2020 06:36

vdemeester approved these changes Dec 16, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2020

bahetiamit force-pushed the power branch from 895dcfc to b2e308e Compare January 4, 2021 08:30

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021

bahetiamit force-pushed the power branch from b2e308e to 9e686e6 Compare January 28, 2021 13:44

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2021

bahetiamit force-pushed the power branch from 9e686e6 to 98641c5 Compare January 29, 2021 09:45

Adding power (ppc64le) architecture image mappings

03b70e9

bahetiamit force-pushed the power branch from 98641c5 to 03b70e9 Compare February 1, 2021 12:52

imjasonh reviewed Feb 18, 2021

View reviewed changes

tekton-robot assigned imjasonh Feb 18, 2021

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2021

tekton-robot merged commit 669255f into tektoncd:master Feb 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding power (ppc64le) architecture image mappings #3630

Adding power (ppc64le) architecture image mappings #3630

bahetiamit commented Dec 11, 2020 •

edited

Loading

tekton-robot commented Dec 11, 2020

ghost commented Dec 11, 2020

tekton-robot commented Dec 11, 2020

tekton-robot commented Dec 14, 2020

vdemeester commented Dec 14, 2020

barthy1 Dec 14, 2020

bahetiamit Dec 14, 2020

barthy1 Dec 14, 2020

bahetiamit Dec 14, 2020

tekton-robot commented Dec 14, 2020

bahetiamit commented Dec 15, 2020

tekton-robot commented Dec 16, 2020

tekton-robot commented Dec 16, 2020

tekton-robot commented Jan 4, 2021

bahetiamit commented Jan 4, 2021

bahetiamit commented Jan 5, 2021

vdemeester commented Jan 5, 2021

bahetiamit commented Jan 8, 2021

bahetiamit commented Jan 13, 2021

tekton-robot commented Jan 28, 2021

bahetiamit commented Jan 28, 2021

bahetiamit commented Jan 29, 2021

tekton-robot commented Jan 29, 2021

bahetiamit commented Feb 1, 2021

vdemeester commented Feb 1, 2021

tekton-robot commented Feb 1, 2021

bahetiamit commented Feb 1, 2021

imjasonh left a comment

imjasonh Feb 18, 2021

Adding power (ppc64le) architecture image mappings #3630

Adding power (ppc64le) architecture image mappings #3630

Conversation

bahetiamit commented Dec 11, 2020 • edited Loading

Changes

Submitter Checklist

Reviewer Notes

Release Notes

tekton-robot commented Dec 11, 2020

ghost commented Dec 11, 2020

tekton-robot commented Dec 11, 2020

tekton-robot commented Dec 14, 2020

vdemeester commented Dec 14, 2020

barthy1 Dec 14, 2020

Choose a reason for hiding this comment

bahetiamit Dec 14, 2020

Choose a reason for hiding this comment

barthy1 Dec 14, 2020

Choose a reason for hiding this comment

bahetiamit Dec 14, 2020

Choose a reason for hiding this comment

tekton-robot commented Dec 14, 2020

bahetiamit commented Dec 15, 2020

tekton-robot commented Dec 16, 2020

tekton-robot commented Dec 16, 2020

tekton-robot commented Jan 4, 2021

bahetiamit commented Jan 4, 2021

bahetiamit commented Jan 5, 2021

vdemeester commented Jan 5, 2021

bahetiamit commented Jan 8, 2021

bahetiamit commented Jan 13, 2021

tekton-robot commented Jan 28, 2021

bahetiamit commented Jan 28, 2021

bahetiamit commented Jan 29, 2021

tekton-robot commented Jan 29, 2021

bahetiamit commented Feb 1, 2021

vdemeester commented Feb 1, 2021

tekton-robot commented Feb 1, 2021

bahetiamit commented Feb 1, 2021

imjasonh left a comment

Choose a reason for hiding this comment

imjasonh Feb 18, 2021

Choose a reason for hiding this comment

bahetiamit commented Dec 11, 2020 •

edited

Loading