Update go-containerregistry from v0.1.3 to v0.2.1. #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
vdemeester
approved these changes
Dec 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like tests are failing trying to pull hello:latest from Dockerhub. I think it's a rate limiting issue! I'll try to figure out why we're pulling this image... |
|
Hmm, that might be a red herring: This is in the dind-sidecar example test, where we first try to build an image then run it. There's no "set -e" in the bash script, so we continue after the image build fails: Status: Downloaded newer image for ubuntu:latest
---> f643c72bc252
Step 2/3 : RUN apt-get update
---> Running in d0dd2faacc8c
io.containerd.runc.v2: failed to adjust OOM score for shim: set shim OOM score: write /proc/343/oom_score_adj: invalid argument
: exit status 1: unknown
REPOSITORY TAG IMAGE ID CREATED SIZE
busybox latest 219ee5171f80 7 days ago 1.23MB
ubuntu latest f643c72bc252 2 weeks ago 72.9MB
Unable to find image 'hello:latest' locally
docker: Error response from daemon: pull access denied for hello, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.
|
|
/retest This still isn't reproing for me... |
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Dec 11, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref tektoncd#3628
4 tasks
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Dec 11, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref tektoncd#3628
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Dec 11, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref tektoncd#3628
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Dec 11, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref tektoncd#3628
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Dec 12, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref tektoncd#3628
dlorenc
pushed a commit
to dlorenc/build-pipeline
that referenced
this pull request
Dec 12, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref tektoncd#3628
v0.1.3 contained a dependency (which contained another...) eventually including a version of jwt-go with CVE-2018-20699 in it. That library has been abandoned, so the Go ecosystem is slowly picking up various changes to remove this dependency. This also required "unpinning" go-autorest, which we seemed to be doing because of knative. Tests build and pass without this, so let's see what happens.
tekton-robot
pushed a commit
that referenced
this pull request
Dec 13, 2020
I was bitten by this test not having one, when the "docker build" failed but we continued on executing anyway. I did a cursory look at the other tests, and they either already have this or are so short/simple that it doesn't matter. Ref #3628
|
/lgtm |
|
/test pull-tekton-pipeline-build-tests |
|
/test pull-tekton-pipeline-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
v0.1.3 contained a dependency (which contained another...) eventually including
a version of jwt-go with CVE-2018-20699 in it. That library has been abandoned,
so the Go ecosystem is slowly picking up various changes to remove this dependency.
This also required "unpinning" go-autorest, which we seemed to be doing because of
knative. Tests build and pass without this, so let's see what happens.
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes