-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run controller and webhook also as non-root group. Drop capabilities. #3611
Conversation
|
Hi @benhxy. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Containers running as root group or with excessive capabilities have larger security impact if compromised. It is recommended to run containers as non-root and drop unneeded capabilities. Controller and Webhook are regular servers and don't need special capabilities. This change is tested with master version on a GKE cluster.
/assign @pritidesai |
/test check-pr-has-kind-label |
/lgtm /cc @vdemeester Thanks! We should probably do this for the other deployments in Tekton too (triggers, operator, results) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Agreed 😉 . This is another thing we will need to "mangle" for OpenShift Pipelines (because OpenShift does a lot of this on its own) but it is a really good thing to do ! /lgtm |
Changes
/kind misc
Containers running as root group or with excessive capabilities
have larger security impact if compromised. It is recommended
to run containers as non-root and drop unneeded capabilities.
Controller and Webhook are regular servers and don't need special
capabilities. This change is tested with master version on a GKE cluster.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.