Make examples runnable with kubectl 🐇 #3564
Conversation
|
/cc @afrittoli |
This remove the use of `ko://` in the examples folder, using the `:latest` release image for those. This allow users to apply those with `kubectl` directly. To keep testing the "currently" built image, this introduce a `test/yamls` folder where we use `ko://`. This updates the tests to run both (`examples` and `test/yamls`). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
afa6a91 to
c37f7dd
Compare
|
/lgtm |
|
Is there any reasons why people would want to run the test without KO ? Just wondering why |
See the linked issue, most people assume that the root |
|
@vdemeester do we need to remove both |
So, I didn't because they are still "valid" example for users to look at, they are just using "normal" images instead of using the |
| @@ -135,7 +142,7 @@ func exampleTest(path string, waitValidateFunc waitFunc, kind string) func(t *te | |||
| t.Skipf("Couldn't substitute environment: %v", err) | |||
| } | |||
|
|
|||
| out, err := koCreate(subbedInput, namespace) | |||
There was a problem hiding this comment.
Super tiny nit: there's a comment on line 151, // Parse from koCreate for now that I think is no longer right with this change? Maybe // Parse from createFunc for now?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Changes
This remove the use of
ko://in the examples folder, using the:latestrelease image for those. This allow users to apply thosewith
kubectldirectly.To keep testing the "currently" built image, this introduce a
test/yamlsfolder where we useko://. This updates the tests torun both (
examplesandtest/yamls).Fixes #3498
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
/area testing
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes