Plumb the "TEKTON_RESOURCE_NAME" environment variable into more resou… #3532
Conversation
…rce containers. As part of TEP-0025 (hermetic builds), we need to know which containers/steps are part of the "Tekton system" and which ones are part of the Task definition. This PR adds the TEKTON_RESOURCE_NAME environment variable to the injected copy containers. This variable is already used by several of the existing resources (git, image).
c084885 to
7f5d9a4
Compare
|
Hey @dlorenc! Is this environment variable at all user facing and would it make sense to include in our docs at all? If it is user facing (it seems like it would be exposed to a user's containers or maybe im misunderstanding?) I want to understand if we're starting to set a precedent of making Env vars available to containers which many CI/CD systems do but so far we've avoided (opting for variable replacement instead) |
No this is explicitly not user facing. This is only set on the non-user-facing containers, as a way for the entrypoint to tell if it is inside a user-facing container or not. |
|
👍 👍 👍 /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Does the entrypoint uses this at all ? What would be the use case for the entrypoint to use it ? Or is it for external tools to know that ? |
…rce containers.
Changes
As part of TEP-0025 (hermetic builds), we need to know which containers/steps are part
of the "Tekton system" and which ones are part of the Task definition. This PR adds
the TEKTON_RESOURCE_NAME environment variable to the injected copy containers.
This variable is already used by several of the existing resources (git, image).
/kind feature
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes