Fix script step on CRI-O runtime #3526
Conversation
For step used script tekton using pod with init container with image configured by "-shell-image". On runtime environment like CRI-O that didn't support images with simultaneously specified tag and digest current configuration leads to: ``` Failed to pull image "gcr.io/distroless/base:debug@sha256:72a0093a0214e414527a97d359313992534f94a689449615875d922097f0ba62": rpc error: code = Unknown desc = Invalid image name "gcr.io/distroless/base:debug@sha256:72a0093a0214e414527a97d359313992534f94a689449615875d922097f0ba62", unknown transport "gcr.io/distroless/base" ``` This changes removed tag and updated image hash for latest available.
|
@izhukov: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
Hi @izhukov. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Thanks for this @izhukov
That's one reason why we have the .notag.yaml release, but indeed, this particular image reference doesn't get "cleaned" by the script.
In which cri-o version does this fail ? I thought the latest release(s) of cri-o fixed that.
|
I've run into this issue on |
|
In fact you are right about current version CRI-O. Just checked on minikube with The main question here, how fast CRI-O users adopted new versions. |
ahah yeah that's one of the question. Overall I am fine with that change, mainly because another container runtime might be affected. /ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/release-note-none |
|
/lgtm |
Changes
Remove tag and update image hash for latest available for -shell-image so CRI-O can successfully fetch and using it.
For step used script tekton using pod with init container with image configured by "-shell-image".
On runtime environment like CRI-O that didn't support images with simultaneously specified tag and digest current configuration leads to:
/kind bug
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.