pkg/apis tests cleanup on duplicate test name 💅 #3495
Conversation
|
/retest |
| if d := cmp.Diff(err.Error(), ps.want.Error()); d != "" { | ||
| t.Errorf("PipelineRun.Validate/%s %s", ps.name, diff.PrintWantGot(d)) | ||
| t.Error(diff.PrintWantGot(d)) |
There was a problem hiding this comment.
nit: got/want needs to be flipped to want/got to make this error msg correct 🤔
There was a problem hiding this comment.
oh on the cmd.Diff, indeed 😅
|
/retest |
acd2d73 to
8e96733
Compare
|
/lgtm |
The error/fatal message should report the name of the test. It is already available when the test fail as it is part of the name of the test. This reduces some duplication and make some tests a bit easier to read and write 😉. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
8e96733 to
28ca2ae
Compare
|
/test all |
|
/retest |
| } | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| sa := tt.pr.GetServiceAccountName(taskName) | ||
| if expected != sa { |
There was a problem hiding this comment.
does expected here need to be shadowed inside the if now that it's wrapped in a t.Run? Or is that only if t.Parallel has been called somewhere else?
There was a problem hiding this comment.
Only if t.Parallel is called inside the t.Run 😉
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Changes
The error/fatal message should report the name of the test. It is
already available when the test fail as it is part of the name of the
test.
This reduces some duplication and make some tests a bit easier to read
and write 😉.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
/area testing
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes