-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add pause condition in pipeline run #3223
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @FogDong. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
/hold This is likely something we'll want a TEP for, so we have a chance to discuss alternatives/trade-offs before proposing code changes. There's already a proposed TEP for pausing PipelineRuns, which might end up overlapping with your proposed feature a lot! Or it might not. Or it might overlap in a confusing/difficult way! Anyway let's discuss more in a TEP 😄 |
This is exactly what was proposed in my TEP. Thanks @FogDong ! |
The pause condition will be valid in runAfter pipelines. When users change the pipeline run's status to paused, after the completion of the current pipeline, the next pipeline that runs after the previous one will be paused.
@FogDong: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
This PR has been cherry picked in another merged PR. /close |
@FogDong: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Feat: Add pause condition in pipeline run.
The pause condition will be valid in runAfter pipelines.
When users change the pipeline run's status to paused, after the
completion of the current pipeline, the next pipeline that runs after
the previous one will be paused.
The way we handle
pause
is similar to the way we handlecancel
.Reference #2217
/cc @withlin
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes