Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readiness and liveness probes to webhook.yaml #3162

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Add readiness and liveness probes to webhook.yaml #3162

merged 1 commit into from
Sep 8, 2020
+11 −0

Conversation

ywluogg
Copy link
Contributor

@ywluogg ywluogg commented Sep 2, 2020 •
edited
Loading

Changes

Tested on cluster:

Name:         tekton-pipelines-controller-b4576868-czwhk
Namespace:    tekton-pipelines
Priority:     0
Node:         gke-cluster-1-default-pool-cd1011d2-pznh/10.128.0.2
Start Time:   Wed, 02 Sep 2020 15:12:17 +0000
Labels:       app=tekton-pipelines-controller
              app.kubernetes.io/component=controller
              app.kubernetes.io/instance=default
              app.kubernetes.io/name=controller
              app.kubernetes.io/part-of=tekton-pipelines
              app.kubernetes.io/version=devel
              pipeline.tekton.dev/release=devel
              pod-template-hash=b4576868
              version=devel
Annotations:  cluster-autoscaler.kubernetes.io/safe-to-evict: false
Status:       Running
IP:           10.4.0.143
IPs:
  IP:           10.4.0.143
Controlled By:  ReplicaSet/tekton-pipelines-controller-b4576868
Containers:
  tekton-pipelines-controller:
    Container ID:  docker://5181010fac3e203791427d7c9b6e8421196c1fe8ad5b516968d70d3d8cd27531
    Image:         gcr.io/yawenluo-test-01-287009/controller-10a3e32792f33651396d02b6855a6e36@sha256:ef7fef74a855f62a155a4773f00c3d6ff685282b961abd6597ef0ee174f334ec
    Image ID:      docker-pullable://gcr.io/yawenluo-test-01-287009/controller-10a3e32792f33651396d02b6855a6e36@sha256:ef7fef74a855f62a155a4773f00c3d6ff685282b961abd6597ef0ee174f334ec
    Port:          <none>
    Host Port:     <none>
    Args:
      -kubeconfig-writer-image
      gcr.io/yawenluo-test-01-287009/kubeconfigwriter-3d37fea0b053ea82d66b7c0bae03dcb0@sha256:c8d46c2abcaf73329d55062046fcf1b08a878b5a00dd7e07d49602d1f9f79672
      -creds-image
      gcr.io/yawenluo-test-01-287009/creds-init-c761f275af7b3d8bea9d50cc6cb0106f@sha256:10cd2a75cbe9bb89a30acafa6ab8fe5fe688e1ac25028b7dc77ace31f645db56
      -git-image
      gcr.io/yawenluo-test-01-287009/git-init-4874978a9786b6625dd8b6ef2a21aa70@sha256:69331e2cd3a53ff7b656e91eda7fc6112f37933bae420724c133bf6ce01093fe
      -entrypoint-image
      gcr.io/yawenluo-test-01-287009/entrypoint-bff0a22da108bc2f16c818c97641a296@sha256:5ac4fac90949ebec3c3d0d394e9fdd1efda5b962ec30a9a82e88883030153a39
      -nop-image
      gcr.io/yawenluo-test-01-287009/nop-8eac7c133edad5df719dc37b36b62482@sha256:3e9eb5e4cd4d658847a27a6de3217581ff362c2ec230f3a4c491706754a82515
      -imagedigest-exporter-image
      gcr.io/yawenluo-test-01-287009/imagedigestexporter-6e7c518e6125f31761ebe0b96cc63971@sha256:329d67792b98cd5d36dcb6cc64fdf62884091b6868b35dc18974b7bddaea14c7
      -pr-image
      gcr.io/yawenluo-test-01-287009/pullrequest-init-4e60f6acf9725cba4c9b0c81d0ba89b8@sha256:86020a90ab91450d064ab4434a127b90c13ba0087b2edcd94c12a64ba662de93
      -build-gcs-fetcher-image
      gcr.io/yawenluo-test-01-287009/gcs-fetcher-029518c065a5d298216f115c6595f133@sha256:6b21cd0afe95ef9bc998cde276da60924ef7d0d3c085b61408e70f04b9bb6c9a
      -gsutil-image
      google/cloud-sdk@sha256:27b2c22bf259d9bc1a291e99c63791ba0c27a04d2db0a43241ba0f1f20f4067f
      -shell-image
      gcr.io/distroless/base@sha256:60f5ffe6fc481e9102747b043b3873a01893a5a8138f970c5f5fc06fb7494656
    State:          Running
      Started:      Wed, 02 Sep 2020 15:12:21 +0000
    Ready:          True
    Restart Count:  0
    Environment:
      SYSTEM_NAMESPACE:             tekton-pipelines (v1:metadata.namespace)
      CONFIG_DEFAULTS_NAME:         config-defaults
      CONFIG_LOGGING_NAME:          config-logging
      CONFIG_OBSERVABILITY_NAME:    config-observability
      CONFIG_ARTIFACT_BUCKET_NAME:  config-artifact-bucket
      CONFIG_ARTIFACT_PVC_NAME:     config-artifact-pvc
      CONFIG_FEATURE_FLAGS_NAME:    feature-flags
      CONFIG_LEADERELECTION_NAME:   config-leader-election
      METRICS_DOMAIN:               tekton.dev/pipeline
    Mounts:
      /etc/config-logging from config-logging (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from tekton-pipelines-controller-token-mmd8c (ro)
Conditions:
  Type              Status
  Initialized       True 
  Ready             True 
  ContainersReady   True 
  PodScheduled      True 
Volumes:
  config-logging:
    Type:      ConfigMap (a volume populated by a ConfigMap)
    Name:      config-logging
    Optional:  false
  tekton-pipelines-controller-token-mmd8c:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  tekton-pipelines-controller-token-mmd8c
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason     Age   From                                               Message
  ----    ------     ----  ----                                               -------
  Normal  Scheduled  19s   default-scheduler                                  Successfully assigned tekton-pipelines/tekton-pipelines-controller-b4576868-czwhk to gke-cluster-1-default-pool-cd1011d2-pznh
  Normal  Pulling    18s   kubelet, gke-cluster-1-default-pool-cd1011d2-pznh  Pulling image "gcr.io/yawenluo-test-01-287009/controller-10a3e32792f33651396d02b6855a6e36@sha256:ef7fef74a855f62a155a4773f00c3d6ff685282b961abd6597ef0ee174f334ec"
  Normal  Pulled     17s   kubelet, gke-cluster-1-default-pool-cd1011d2-pznh  Successfully pulled image "gcr.io/yawenluo-test-01-287009/controller-10a3e32792f33651396d02b6855a6e36@sha256:ef7fef74a855f62a155a4773f00c3d6ff685282b961abd6597ef0ee174f334ec"
  Normal  Created    16s   kubelet, gke-cluster-1-default-pool-cd1011d2-pznh  Created container tekton-pipelines-controller
  Normal  Started    15s   kubelet, gke-cluster-1-default-pool-cd1011d2-pznh  Started container tekton-pipelines-controller


Name:         tekton-pipelines-webhook-5768cd6697-bdh44
Namespace:    tekton-pipelines
Priority:     0
Node:         gke-cluster-1-default-pool-cd1011d2-ddh8/10.128.0.3
Start Time:   Wed, 02 Sep 2020 15:12:17 +0000
Labels:       app=tekton-pipelines-webhook
              app.kubernetes.io/component=webhook
              app.kubernetes.io/instance=default
              app.kubernetes.io/name=webhook
              app.kubernetes.io/part-of=tekton-pipelines
              app.kubernetes.io/version=devel
              pipeline.tekton.dev/release=devel
              pod-template-hash=5768cd6697
              version=devel
Annotations:  cluster-autoscaler.kubernetes.io/safe-to-evict: false
Status:       Running
IP:           10.4.1.207
IPs:
  IP:           10.4.1.207
Controlled By:  ReplicaSet/tekton-pipelines-webhook-5768cd6697
Containers:
  webhook:
    Container ID:   docker://43397322997b6d3639310283aa28c6354da5993fadafc627e75701d941d41ea0
    Image:          gcr.io/yawenluo-test-01-287009/webhook-d4749e605405422fd87700164e31b2d1@sha256:b96b03001b5e00a10782a5144bb0e5a7ef9acc874d3dac0f9c3cbf25572f2b63
    Image ID:       docker-pullable://gcr.io/yawenluo-test-01-287009/webhook-d4749e605405422fd87700164e31b2d1@sha256:b96b03001b5e00a10782a5144bb0e5a7ef9acc874d3dac0f9c3cbf25572f2b63
    Ports:          9090/TCP, 8008/TCP, 8443/TCP
    Host Ports:     0/TCP, 0/TCP, 0/TCP
    State:          Running
      Started:      Wed, 02 Sep 2020 15:12:21 +0000
    Ready:          True
    Restart Count:  0
    Liveness:       tcp-socket :https-webhook delay=5s timeout=5s period=10s #success=1 #failure=3
    Readiness:      tcp-socket :https-webhook delay=5s timeout=1s period=10s #success=1 #failure=3
    Environment:
      SYSTEM_NAMESPACE:            tekton-pipelines (v1:metadata.namespace)
      CONFIG_LOGGING_NAME:         config-logging
      CONFIG_OBSERVABILITY_NAME:   config-observability
      CONFIG_LEADERELECTION_NAME:  config-leader-election
      WEBHOOK_SERVICE_NAME:        tekton-pipelines-webhook
      WEBHOOK_SECRET_NAME:         webhook-certs
      METRICS_DOMAIN:              tekton.dev/pipeline
    Mounts:
      /var/run/secrets/kubernetes.io/serviceaccount from tekton-pipelines-webhook-token-269mb (ro)
Conditions:
  Type              Status
  Initialized       True 
  Ready             True 
  ContainersReady   True 
  PodScheduled      True 
Volumes:
  tekton-pipelines-webhook-token-269mb:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  tekton-pipelines-webhook-token-269mb
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason     Age   From                                               Message
  ----    ------     ----  ----                                               -------
  Normal  Scheduled  19s   default-scheduler                                  Successfully assigned tekton-pipelines/tekton-pipelines-webhook-5768cd6697-bdh44 to gke-cluster-1-default-pool-cd1011d2-ddh8
  Normal  Pulling    18s   kubelet, gke-cluster-1-default-pool-cd1011d2-ddh8  Pulling image "gcr.io/yawenluo-test-01-287009/webhook-d4749e605405422fd87700164e31b2d1@sha256:b96b03001b5e00a10782a5144bb0e5a7ef9acc874d3dac0f9c3cbf25572f2b63"
  Normal  Pulled     16s   kubelet, gke-cluster-1-default-pool-cd1011d2-ddh8  Successfully pulled image "gcr.io/yawenluo-test-01-287009/webhook-d4749e605405422fd87700164e31b2d1@sha256:b96b03001b5e00a10782a5144bb0e5a7ef9acc874d3dac0f9c3cbf25572f2b63"
  Normal  Created    15s   kubelet, gke-cluster-1-default-pool-cd1011d2-ddh8  Created container webhook
  Normal  Started    15s   kubelet, gke-cluster-1-default-pool-cd1011d2-ddh8  Started container webhook

Because existing tests will run the cluster, which will test this feature, so currently I don't think extra tests are needed. Let me know if extra testing is needed.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Liveness and readiness probes are available for webhook.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 2, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2020
@tekton-robot
Copy link
Collaborator

Hi @ywluogg. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 2, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 2, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 2, 2020

#1586

@dibyom
Copy link
Member

dibyom commented Sep 2, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 4, 2020

/assign @dlorenc

vdemeester
vdemeester reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2020
@imjasonh
Copy link
Member

imjasonh commented Sep 8, 2020

/lgtm
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Sep 8, 2020

/retest

@tekton-robot tekton-robot merged commit 3c0d089 into tektoncd:master Sep 8, 2020
@ywluogg ywluogg mentioned this pull request Sep 9, 2020
Closed
@GregDritschler GregDritschler mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester left review comments

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@vdemeester vdemeester

@imjasonh imjasonh

@dlorenc dlorenc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ywluogg @tekton-robot @dibyom @imjasonh @vdemeester @dlorenc