Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /bin/ash from examples #3143

Merged

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Aug 27, 2020

Changes

Removed /bin/ash from the example because some of the images don't support.
with #!/bin/ash shbang example fails with below error if use rhel ubi image

2020/08/26 20:41:20 Error executing command: fork/exec /tekton/scripts/script-0-wz2x6: no such file or directory

Signed-off-by: Savita Ashture sashture@redhat.com

/cc @vdemeester

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

None

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2020
@savitaashture
Copy link
Contributor Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Aug 27, 2020
@chmouel
Copy link
Member

chmouel commented Aug 27, 2020

Do we really need to have a shbang? AFAIK the controller will set this up as /bin/sh by default if it doesn't see any, so we may just simply remove them, isn't it ?

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@piyush-garg
Copy link
Contributor

Do we really need to have a shbang? AFAIK the controller will set this up as /bin/sh by default if it doesn't see any, so we may just simply remove them, isn't it ?

I agree with @chmouel Here, it should work without it also

@savitaashture savitaashture force-pushed the sh-update-example-pipeline branch from c0f431f to 847f9f6 Compare August 27, 2020 11:50
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
@savitaashture savitaashture changed the title Update examples to use /bin/sh instead of /bin/ash Remove /bin/ash from examples Aug 27, 2020
@savitaashture
Copy link
Contributor Author

Do we really need to have a shbang? AFAIK the controller will set this up as /bin/sh by default if it doesn't see any, so we may just simply remove them, isn't it ?

@chmouel yes i agree 👍
It works without shbang updated PR
Thank you 🙂

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@chmouel
Copy link
Member

chmouel commented Aug 27, 2020

/lgtm

Looking Good! 🤙🏽

@piyush-garg
Copy link
Contributor

/retest

@vdemeester vdemeester added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/misc Categorizes issue or PR as a miscellaneuous one. labels Aug 27, 2020
@piyush-garg
Copy link
Contributor

/retest

@tekton-robot tekton-robot merged commit 9be0bb3 into tektoncd:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants