Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #1131, Enable graceful sidecar kill #3013

Closed
wants to merge 24 commits into from
Closed

Fixes: #1131, Enable graceful sidecar kill #3013

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d89c16a
Enable graceful sidecar shutdown
Jul 15, 2020
a44ac03
make it a config per sidecar
Jul 16, 2020
e848be8
make Sidecar an Alias of sidecar again
Jul 16, 2020
93facce
Fix DeepCopy
Jul 17, 2020
a7382cf
fix step converstion for sidecars
Jul 19, 2020
1f508d0
Merge branch 'master' into feature-enable-graceful-sidecar-kill
Jul 20, 2020
64d0f5d
fix tests
Jul 21, 2020
a3e768a
fix go mod
Jul 21, 2020
35db648
Consider injected sidecars
Jul 22, 2020
442245a
fix doc
Jul 22, 2020
cff494b
Added test
Jul 24, 2020
4c65440
remove blank line comment
Jul 24, 2020
b28aa4f
Merge branch 'master' into feature-enable-graceful-sidecar-kill
Jul 24, 2020
198f088
add docs
Jul 24, 2020
fc3b305
Update go mod
Jul 24, 2020
5d0c233
fix typo
Jul 24, 2020
6d592a9
add some verbosity
Jul 24, 2020
ca15cec
fix nil pointer dereference
Jul 24, 2020
cc993d6
fix sidecar retrieval
Jul 24, 2020
f18e866
add a way to include taskspec into taskrun status
Jul 26, 2020
2af6970
Merge branch 'master' into feature-enable-graceful-sidecar-kill
Jul 28, 2020
b922612
Merge branch 'master' into feature-enable-graceful-sidecar-kill
Aug 16, 2020
de2c918
use waitForTermination instead of forceTerminationDisabled as suggest…
Aug 16, 2020
5f2adf2
remove gotest.tools
Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix sidecar retrieval
  • Loading branch information
Shahnewaz Rifat committed Jul 24, 2020
commit cc993d63c31f747de907adeba3fe30f9fae70a83
5 changes: 3 additions & 2 deletions pkg/reconciler/taskrun/taskrun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,9 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, tr *v1beta1.TaskRun) pkg
c.timeoutHandler.Release(tr)
pod, err := c.KubeClientSet.CoreV1().Pods(tr.Namespace).Get(tr.Status.PodName, metav1.GetOptions{})
if err == nil {
fmt.Println("Stopping sidecars that are not marked for exemption.")
stoppableContainers := getStoppableContainers(pod, tr.Spec.TaskSpec.Sidecars)
fmt.Println("Stopping Sidecars that were not marked for exemption.")
sidecars := tr.Status.TaskSpec.Sidecars
stoppableContainers := getStoppableContainers(pod, sidecars)
err := podconvert.StopSidecars(c.Images.NopImage, c.KubeClientSet, *pod, &stoppableContainers)
if err == nil {
// Check if any SidecarStatuses are still shown as Running after stopping
Expand Down