Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace variable interpolation for pipelinerun namespace and #2926

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

R2wenD2
Copy link
Contributor

@R2wenD2 R2wenD2 commented Jul 9, 2020

taskrun namespace

Changes

Add namespace variable interpolation for pipelinerun namespace and taskrun namespace this will be the final diff for #1522

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [ X] Includes tests (if functionality changed/added)
  • [ X] Includes docs (if user facing)
  • [ X] Commit messages follow commit message best practices
  • [ X] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 9, 2020
@tekton-robot tekton-robot requested review from a user and vdemeester July 9, 2020 21:58
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2020
@R2wenD2
Copy link
Contributor Author

R2wenD2 commented Jul 9, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 9, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions on the tests but the change itself lgtm

pkg/reconciler/taskrun/resources/apply_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@R2wenD2
Copy link
Contributor Author

R2wenD2 commented Jul 10, 2020

Thanks for the review, good catches - just a few copy/paste errors in the taskrun test.

@dibyom
Copy link
Member

dibyom commented Jul 10, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@tekton-robot tekton-robot merged commit 2b274a4 into tektoncd:master Jul 10, 2020
@R2wenD2 R2wenD2 deleted the var branch July 10, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants