Emit event only once #2860
Emit event only once #2860
Conversation
|
/cc @bobcatfish |
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
When finishReconcileUpdateEmitEvents was introduced in PR tektoncd#2805, I forgot to remove one of the original event.Emit, so one event was sent twice. The fake recorder sometimes probably recognised the duplicate and filtered it out, causing flackiness in tests, as unit tests expect a fixed number of events. Thanks @GregDritschler for troubleshooting this! Fixes: tektoncd#2857
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
When finishReconcileUpdateEmitEvents was introduced in PR #2805,
I forgot to remove one of the original event.Emit, so one event
was sent twice. The fake recorder sometimes probably recognised
the duplicate and filtered it out, causing flackiness in tests,
as unit tests expect a fixed number of events.
Thanks @GregDritschler for troubleshooting this!
Fixes: #2857
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
/kind bug