Add checklist item for release notes ✅ #2820
Conversation
While looking into tektoncd#2816 we realized that tektoncd#2501 had indicated that this will require users to delete their Deployments but since the note wasn't in a release notes block it was missed (by me!) Adding this to the checklist might help contributors and reviewers be more aware. We also found that prow has a "release notes" plugin that might check this for us on PRs if we turn it on: https://github.com/kubernetes/test-infra/blob/128455dfd8003346afcdffa111d2298587f6fbf0/prow/plugins/releasenote/releasenote.go Co-authored-by: Sharon Jerop Kipruto <jerop@google.com>
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
/kind documentation |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
While looking into #2816
we realized that #2501 had
indicated that this will require users to delete their Deployments but
since the note wasn't in a release notes block it was missed (by me!)
Adding this to the checklist might help contributors and reviewers be
more aware.
We also found that prow has a "release notes" plugin that might
check this for us on PRs if we turn it on:
https://github.com/kubernetes/test-infra/blob/128455dfd8003346afcdffa111d2298587f6fbf0/prow/plugins/releasenote/releasenote.go
Co-authored-by: Sharon Jerop Kipruto jerop@google.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.