Change the storage version to v1beta1 types #2577

vdemeester · 2020-05-07T18:01:17Z

Changes

This changes the stored version to v1beta1 👼 This will reduce some confusion on where to add fields and how to work with which version in most of the tektoncd/pipeline code.
Still a little bit of work to do:

ResolvedTask… builders are gone, use struct for those
Fix the unit tests
Fix the integration tests
Update the documentation with link to https://github.com/kubernetes-sigs/kube-storage-version-migrator

Closes #2410

/kind cleanup

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Change the storage version to v1beta1 types

vdemeester · 2020-05-07T18:02:33Z

internal/builder/v1alpha1/task.go

@@ -22,7 +22,6 @@ import (
 	"github.com/tektoncd/pipeline/pkg/apis/config"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
-	"github.com/tektoncd/pipeline/pkg/reconciler/taskrun/resources"


We should never import pkg/reconciler packages outside of pkg/reconciler 😈

tekton-robot · 2020-05-07T18:05:29Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/pipelinerun.go	72.4%	72.5%	0.1
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7

ghost · 2020-05-08T12:30:32Z

very exciting. cant wait for v1beta1 everywhere!

tekton-robot · 2020-05-11T10:12:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	34.1%	-40.6
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

tekton-robot · 2020-05-11T10:35:17Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

tekton-robot · 2020-05-11T10:40:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

tekton-robot · 2020-05-11T10:50:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

tekton-robot · 2020-05-11T11:26:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

vdemeester · 2020-05-11T11:28:39Z

# github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun/resources
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go:266:39: undefined: v1alpha1

pipeline/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go

Line 266 in c71660e

type TaskNotFoundError struct {

I don't understand 🤔

tekton-robot · 2020-05-11T11:39:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

tekton-robot · 2020-05-11T11:44:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/pipelinerun.go	72.0%	73.2%	1.2
pkg/reconciler/pipelinerun/resources/conditionresolution.go	81.7%	82.0%	0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	90.1%	90.5%	0.4
pkg/reconciler/pipelinerun/resources/pipelinespec.go	92.9%	100.0%	7.1
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

vdemeester · 2020-05-11T12:46:29Z

@sbwsg @bobcatfish we can provide a job to do the upgrade (as serving does here : https://github.com/knative/serving/blob/master/config/post-install/storage-version-migration.yaml). I think it should be only part of the documentation (not deployed as part of ko apply -f config/) and it would be more than nice to have it in the operator (cc @nikhil-thomas)

ghost · 2020-05-11T13:29:45Z

Conflicting files

pkg/apis/pipeline/v1beta1/taskrun_defaults_test.go
pkg/apis/resource/v1alpha1/git/git_resource_test.go
pkg/reconciler/pipelinerun/pipelinerun_test.go
pkg/reconciler/pipelinerun/resources/apply_test.go
pkg/reconciler/pipelinerun/resources/conditionresolution_test.go
pkg/reconciler/pipelinerun/resources/input_output_steps_test.go
pkg/reconciler/pipelinerun/resources/pipelinerunresolution_test.go
pkg/reconciler/taskrun/resources/cloudevent/cloudevent_test.go
pkg/reconciler/taskrun/resources/image_exporter_test.go
pkg/reconciler/taskrun/taskrun_test.go

D: my apologies, i guess these all stem from the cmp.Diff changeset.

vdemeester · 2020-05-11T13:31:00Z

🙀

vdemeester · 2020-05-11T13:40:48Z

@sbwsg should be fixed 🎐

ghost · 2020-05-11T13:41:50Z

@sbwsg @bobcatfish we can provide a job to do the upgrade (as serving does here : https://github.com/knative/serving/blob/master/config/post-install/storage-version-migration.yaml). I think it should be only part of the documentation (not deployed as part of ko apply -f config/)

I like the idea of documenting this in its first iteration. Would it become a part of any future release, do you think?

I guess the idea is to not break anyone who's happy with their alpha tasks and doesn't want to rock the boat with an upgrade. But are these folks even upgrading? And then how long should we be supporting them? That might be a bigger question than we can answer here though.

tekton-robot · 2020-05-11T13:42:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/pipelinerun.go	72.0%	73.2%	1.2
pkg/reconciler/pipelinerun/resources/conditionresolution.go	81.7%	82.0%	0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	90.1%	90.5%	0.4
pkg/reconciler/pipelinerun/resources/pipelinespec.go	92.9%	100.0%	7.1
pkg/reconciler/pipelinerun/resources/resultrefresolution.go	87.5%	88.6%	1.1
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

tekton-robot · 2020-05-11T13:52:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	85.7%	88.6%	2.9
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/pipelinerun.go	72.0%	73.2%	1.2
pkg/reconciler/pipelinerun/resources/conditionresolution.go	81.7%	82.0%	0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	90.1%	90.5%	0.4
pkg/reconciler/pipelinerun/resources/pipelinespec.go	92.9%	100.0%	7.1
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

vdemeester · 2020-05-11T14:32:05Z

/test pull-tekton-pipeline-integration-tests

ghost · 2020-05-11T15:42:02Z

pkg/pod/pod_test.go

 		want            *corev1.PodSpec
 		wantAnnotations map[string]string
 	}{{
 		desc: "simple",
-		ts: v1alpha1.TaskSpec{TaskSpec: v1beta1.TaskSpec{
-			Steps: []v1alpha1.Step{{Container: corev1.Container{
+		ts: v1beta1.TaskSpec{


ghost

I read through and I guess my only question is: are we at a point where chunks of the v1alpha1 packages can start to be deleted? Or is that still a ways off?

tekton-robot · 2020-05-11T15:45:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vdemeester · 2020-05-11T15:54:48Z

I read through and I guess my only question is: are we at a point where chunks of the v1alpha1 packages can start to be deleted? Or is that still a ways off?

We can start to think about it but… if it affects the API served, we need to make a deprecation notice on the CRDs not in v1alpha1 anymore (and I think we should take some time). But in a gist, yes, after this PR gets merged, we can start cleaning the v1alpha1 package with stuff that will never be executed (I need to check the order of things, but some validation and defaulting might be done after the conversion and thus not required anymore). Also we can clean the struct themselves if we feel like it (aka removing the embedded types, …) but this is gonna break the Go API so… we need to be careful.

pritidesai · 2020-05-11T17:46:58Z

pkg/reconciler/pipelinerun/resources/input_output_steps_test.go

@@ -21,7 +21,8 @@ import (

 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
-	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1alpha1"
+	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
+	resourcev1alpha1 "github.com/tektoncd/pipeline/pkg/apis/resource/v1alpha1"


much cleaner 👍

pritidesai · 2020-05-11T18:01:14Z

pkg/reconciler/taskrun/resources/image_exporter_test.go

 						Type: "image",
-						Params: []v1alpha1.ResourceParam{{
+						Params: []v1beta1.ResourceParam{{


Should this be Params: []resourcev1alpha1.ResourceParam instead of Params: []v1beta1.ResourceParam? 🤔

pritidesai · 2020-05-11T18:54:11Z

thanks @vdemeester
/lgtm but it has conflicts now 😢

tekton-robot · 2020-05-12T08:56:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.1%	90.5%	2.4
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/resources/conditionresolution.go	81.7%	82.0%	0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	90.1%	90.5%	0.4
pkg/reconciler/pipelinerun/resources/pipelinespec.go	92.9%	100.0%	7.1
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

- switch storage to v1beta1 for CRDs (config/) - use v1beta1 in controllers, … Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

tekton-robot · 2020-05-12T09:06:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
internal/builder/v1alpha1/task.go	68.4%	66.4%	-2.0
pkg/apis/pipeline/v1beta1/condition_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1beta1/container_replacements.go	Do not exist	100.0%
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	88.1%	90.5%	2.4
pkg/apis/pipeline/v1beta1/resource_paths.go	Do not exist	85.7%
pkg/apis/pipeline/v1beta1/step_replacements.go	Do not exist	100.0%
pkg/reconciler/pipelinerun/pipelinerun.go	72.0%	73.3%	1.2
pkg/reconciler/pipelinerun/resources/conditionresolution.go	81.7%	82.0%	0.3
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go	90.1%	90.5%	0.4
pkg/reconciler/pipelinerun/resources/pipelinespec.go	92.9%	100.0%	7.1
pkg/reconciler/taskrun/resources/taskspec.go	93.3%	100.0%	6.7
pkg/reconciler/taskrun/taskrun.go	74.7%	75.5%	0.8
pkg/reconciler/taskrun/validate_resources.go	91.8%	95.1%	3.3

vdemeester · 2020-05-12T09:32:26Z

/test pull-tekton-pipeline-integration-tests

afrittoli

Nice work, thank you so much!!!
/lgtm

afrittoli · 2020-05-12T09:55:27Z

pkg/apis/pipeline/v1beta1/resource_paths_test.go

@@ -0,0 +1,81 @@
+/*
+ Copyright 2019 The Tekton Authors


Very NIT: should we update the year in the copyright statements of the new files in the beta folder?

vdemeester · 2020-05-12T13:00:51Z

/test pull-tekton-pipeline-integration-tests

bobcatfish · 2020-05-13T13:33:54Z

YAAAAASSS!!!! 🎉

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 7, 2020

tekton-robot requested review from bobcatfish and dlorenc May 7, 2020 18:01

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 7, 2020

vdemeester commented May 7, 2020

View reviewed changes

vdemeester mentioned this pull request May 8, 2020

refactor pipeline validation unit tests v1beta1 #2581

Merged

3 tasks

vdemeester force-pushed the 2410-v1beta1-storage branch from d378b44 to 2ac5e0e Compare May 11, 2020 10:09

vdemeester force-pushed the 2410-v1beta1-storage branch from 2ac5e0e to c76feb3 Compare May 11, 2020 10:28

vdemeester force-pushed the 2410-v1beta1-storage branch from c76feb3 to 9c16f2a Compare May 11, 2020 10:37

vdemeester force-pushed the 2410-v1beta1-storage branch from 9c16f2a to 55427ec Compare May 11, 2020 10:47

vdemeester force-pushed the 2410-v1beta1-storage branch from 55427ec to c71660e Compare May 11, 2020 11:22

vdemeester force-pushed the 2410-v1beta1-storage branch 2 times, most recently from aa8e64c to 5b92e22 Compare May 11, 2020 11:35

vdemeester force-pushed the 2410-v1beta1-storage branch from 5b92e22 to 79734a2 Compare May 11, 2020 11:40

vdemeester changed the title ~~wip: Change the storage version to v1beta1 types~~ Change the storage version to v1beta1 types May 11, 2020

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2020

vdemeester force-pushed the 2410-v1beta1-storage branch from 79734a2 to ca8ff88 Compare May 11, 2020 13:38

vdemeester force-pushed the 2410-v1beta1-storage branch from ca8ff88 to d21e298 Compare May 11, 2020 13:48

ghost reviewed May 11, 2020

View reviewed changes

ghost approved these changes May 11, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020

pritidesai reviewed May 11, 2020

View reviewed changes

vdemeester force-pushed the 2410-v1beta1-storage branch from d21e298 to 8d250e4 Compare May 12, 2020 08:52

Use v1beta1 in controllers 🍸

a01d514

- switch storage to v1beta1 for CRDs (config/) - use v1beta1 in controllers, … Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

vdemeester force-pushed the 2410-v1beta1-storage branch from 8d250e4 to a01d514 Compare May 12, 2020 09:00

afrittoli reviewed May 12, 2020

View reviewed changes

tekton-robot assigned afrittoli May 12, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020

tekton-robot merged commit 1fbac2a into tektoncd:master May 12, 2020

vdemeester deleted the 2410-v1beta1-storage branch May 12, 2020 13:37

dghubble mentioned this pull request May 12, 2020

Change TimeoutHandler to respect namespace scoping #2604

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the storage version to v1beta1 types #2577

Change the storage version to v1beta1 types #2577

vdemeester commented May 7, 2020 •

edited

Loading

vdemeester May 7, 2020

bobcatfish May 7, 2020

tekton-robot commented May 7, 2020

ghost commented May 8, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

ghost commented May 11, 2020

vdemeester commented May 11, 2020

vdemeester commented May 11, 2020

ghost commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

ghost May 11, 2020

ghost left a comment

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

pritidesai May 11, 2020

pritidesai May 11, 2020

pritidesai commented May 11, 2020

tekton-robot commented May 12, 2020

tekton-robot commented May 12, 2020

vdemeester commented May 12, 2020

afrittoli left a comment

afrittoli May 12, 2020

vdemeester commented May 12, 2020

bobcatfish commented May 13, 2020

Change the storage version to v1beta1 types #2577

Change the storage version to v1beta1 types #2577

Conversation

vdemeester commented May 7, 2020 • edited Loading

Changes

Submitter Checklist

Reviewer Notes

Release Notes

vdemeester May 7, 2020

Choose a reason for hiding this comment

bobcatfish May 7, 2020

Choose a reason for hiding this comment

tekton-robot commented May 7, 2020

ghost commented May 8, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

ghost commented May 11, 2020

vdemeester commented May 11, 2020

vdemeester commented May 11, 2020

ghost commented May 11, 2020

tekton-robot commented May 11, 2020

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

ghost May 11, 2020

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

tekton-robot commented May 11, 2020

vdemeester commented May 11, 2020

pritidesai May 11, 2020

Choose a reason for hiding this comment

pritidesai May 11, 2020

Choose a reason for hiding this comment

pritidesai commented May 11, 2020

tekton-robot commented May 12, 2020

tekton-robot commented May 12, 2020

vdemeester commented May 12, 2020

afrittoli left a comment

Choose a reason for hiding this comment

afrittoli May 12, 2020

Choose a reason for hiding this comment

vdemeester commented May 12, 2020

bobcatfish commented May 13, 2020

vdemeester commented May 7, 2020 •

edited

Loading