Emit events from the PipelineRun controller #2545
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on the affected files.
|
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
df1a567 to
9ea2fa7
Compare
|
The following is the coverage report on the affected files.
|
9ea2fa7 to
e3ee453
Compare
|
The following is the coverage report on the affected files.
|
e3ee453 to
3da3c74
Compare
|
The following is the coverage report on the affected files.
|
3da3c74 to
67184d6
Compare
|
The following is the coverage report on the affected files.
|
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
67184d6 to
f00dd88
Compare
I'll try to break this down small pieces out of this where possible.
|
Emit events: - Pipeline Start - Pipeline Started Running - Various Error Conditions, Cancel, Timeout Emit all events through the events.go module. Align and simplify the reconcile structure to have clear points for error handling and emitting events. Added test for the normal reconcile to completion case. Added more event checks to existing tests.
86823f0 to
55b2db7
Compare
|
I addressed the initial comments, but I've not split this one yet. |
|
There are a few things happening:
Roughly I can try to see if I can make a PR for each of this. @bobcatfish does it make sense? |
Sounds great to me @afrittoli , apologies for the extra work. I think in particular having these pieces separated out into 1 or 2 PRs would help a lot:
|
| @@ -208,8 +236,10 @@ func TestReconcile(t *testing.T) { | |||
| defer cancel() | |||
| c := testAssets.Controller | |||
| clients := testAssets.Clients | |||
| reconciler := c.Reconciler.(*Reconciler) | |||
| fr := reconciler.Recorder.(*record.FakeRecorder) | |||
There was a problem hiding this comment.
This should be updated the same way it was done for the taskrun reconciler tests
Using permanent errors: #2798 |
|
/hold |
|
@afrittoli: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
|
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
|
@tekton-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-lifecycle rotten |
|
@vdemeester: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@afrittoli: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@afrittoli what is the status here ? |
|
This PR has been broken down into pieces and merged. |
Changes
Emit events from the PipelineRun controller
Emit events:
Emit all events through the events.go module.
Align and simplify the reconcile structure to have clear points
for error handling and emitting events.
Added test for the normal reconcile to completion case.
Added more event checks to existing tests.
Partially addresses #2474
Partially addresses #2082
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes