Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the Tasks documentation for clarity and flow. #2317

Merged
merged 3 commits into from
Apr 6, 2020
Merged

Rewrite the Tasks documentation for clarity and flow. #2317

merged 3 commits into from
Apr 6, 2020

Conversation

tualeron
Copy link
Contributor

@tualeron tualeron commented Apr 1, 2020 •
edited
Loading

Rewrites the Tasks documentation for clarity and flow.

@tualeron
Rewrite the Tasks documentation for clarity and flow.
931416d 
Rewrites the `Tasks` documentation for clarity and flow.
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 1, 2020
@tekton-robot tekton-robot requested review from abayer and dlorenc April 1, 2020 19:28
@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 1, 2020
ghost
ghost reviewed Apr 2, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, it looks great so far. I've only read through half atm. Wanted to get the feedback out now and I'll pick up the review again a little later.

docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
@tualeron
Address review comments.
f87c7b8 
Addresses review comments.
bobcatfish
bobcatfish reviewed Apr 3, 2020
View reviewed changes
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated Show resolved Hide resolved
bobcatfish
bobcatfish reviewed Apr 3, 2020
View reviewed changes
Copy link
Collaborator

@bobcatfish bobcatfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super excited about these improvements!!!

docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Outdated
- [Storing execution results](#storing-execution-results)
- [Specifying `Volumes`](#configuring-volumes)
- [Specifying a `Step` template](#specifying-a-step-template)
- [Using `Sidecars`](#using-sidecars)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this link needs to be updated too - im gonna stop clicking on all of them now and just recommend trying out all the links :D

docs/tasks.md Outdated Show resolved Hide resolved
docs/tasks.md Show resolved Hide resolved
@tualeron
Fix all the links.
c4e5fc6 
Fixes all the broken links.
vdemeester
vdemeester approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@sergetron can you squash your commits ? 👼 🙏

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow

@sergetron can you squash your commits ? 👼 🙏

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
@ghost
Copy link

ghost commented Apr 6, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Apr 6, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@tekton-robot tekton-robot merged commit 99f679c into tektoncd:master Apr 6, 2020
@ghost ghost added needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch and removed needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch labels Apr 16, 2020
@tualeron tualeron deleted the patch-3 branch April 22, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish bobcatfish left review comments

@vdemeester vdemeester vdemeester approved these changes

@abayer abayer Awaiting requested review from abayer

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tualeron @tekton-robot @vdemeester @bobcatfish @googlebot