-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc about migrating from v1alpha1 to v1beta1 #2231
Conversation
### Image Resource | ||
|
||
WIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is trickier than the other. We can provide a task for it, but most likely it's way more efficient to have a step for the image builder that support this, like here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh I see. So instead of an explicit Task called "ImageOutput", this is really just replaced with a digest result / params or similar. And any task that generates an image could receive / output those. Makes sense.
/kind documentation |
We don't currently have any documentation that's specific to migration from v1alpha1 to v1beta1. This commit introduces a doc describing how to migrate. It details changes in the format of inputs/outputs as well as documenting suggested alternatives for some PipelineResources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@googlebot rescan |
@sbwsg could we add a link to this somewhere, maybe from the main README? maybe even on the website? |
Opened a PR to add a link to the readme: #2351 |
Changes
We don't currently have any documentation that's specific to migration from v1alpha1 to v1beta1.
This commit introduces a doc describing how to migrate. It details changes in the format of inputs/outputs as well as documenting suggested alternatives for some PipelineResources.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes