Add a using resources section in resources.md #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vdemeester
reviewed
Sep 3, 2019
docs/resources.md
Outdated
| Input resources can be accessed by: | ||
|
|
||
| ```shell | ||
| $(resources.<name>.<key> |
d9649ca to
edd444a
Compare
|
/test pull-tekton-pipeline-build-tests |
1 similar comment
|
/test pull-tekton-pipeline-build-tests |
ghost
reviewed
Sep 3, 2019
|
one minor quibble but otherwise this lgtm |
The docs for using resources especially around how resource paths work were in a bunch of different places in tasks.md and taskruns.md. This commit consolidates them into resources.md so that both tasks and condition docs can refer to a single place. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
edd444a to
9af24cb
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The docs for using resources especially around how
resource paths work were in a bunch of different places
in tasks.md and taskruns.md. This commit consolidates
them into resources.md so that both tasks and condition docs
can refer to a single place.
Based on PR feedback in #1151 (comment)