Delete gopath-test taskrun example / YAML test #1224
Conversation
This example doesn't demonstrate much, and it's the longest-running YAML test at about 3-5 minutes. It was copied over from knative/build days and hasn't seen many updates since. The example clones github.com/tektoncd/pipeline into a targetPath within $GOPATH and runs `go test ./...` on it, which is what takes so long. If we decide this example is worth keeping around, we should probably at least change the repo to something smaller and quicker to test, or change `go test` to just `go build` to save time.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
As long as we have other tests using /lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
im going to have to start finding my own space cats |
|
|
Changes
This example doesn't demonstrate much, and it's the longest-running YAML
test at about 3-5 minutes. It was copied over from knative/build days
and hasn't seen many updates since.
The example clones github.com/tektoncd/pipeline into a targetPath within
$GOPATH and runs
go test ./...on it, which is what takes so long.If we decide this example is worth keeping around, we should probably at
least change the repo to something smaller and quicker to test, or
change
go testto justgo buildto save time.Submitter Checklist