Refactor the Storage resource interface to remove a type switch state… #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment. Right now the upload phase for artifacts needs to behave differently between normal resources and storage (GCS, BuildGCS) resources, leading to type switches in this code. This refactor moves that logic up into the normal Resource interface, allowing the logic to remain uniform between the two resource types.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
The following is the coverage report on pkg/.
|
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 31, 2019
…ment. This change refactors the way input resources attach volumes to their steps. Previously, there was a special-cased switch statement for Storage type resources. This made the logic for resources hard to follow, and spread across the codebase. This change refactors that by moving it up into the general Resource interface. This is another follow-on to tektoncd#1135
3 tasks
dlorenc
added a commit
to dlorenc/build-pipeline
that referenced
this pull request
Jul 31, 2019
…ment. This change refactors the way input resources attach volumes to their steps. Previously, there was a special-cased switch statement for Storage type resources. This made the logic for resources hard to follow, and spread across the codebase. This change refactors that by moving it up into the general Resource interface. This is another follow-on to tektoncd#1135
tekton-robot
pushed a commit
that referenced
this pull request
Jul 31, 2019
…ment. This change refactors the way input resources attach volumes to their steps. Previously, there was a special-cased switch statement for Storage type resources. This made the logic for resources hard to follow, and spread across the codebase. This change refactors that by moving it up into the general Resource interface. This is another follow-on to #1135
|
yussssssss |
|
hm but it looks like all the coverage went down |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ment.
Changes
Right now the upload phase for artifacts needs to behave differently between
normal resources and storage (GCS, BuildGCS) resources, leading to type switches
in this code.
This refactor moves that logic up into the normal Resource interface, allowing the
logic to remain uniform between the two resource types.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.