Preserve permissions when copying to/from an artifact storage bucket #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were calling `gsutil cp -r ...`, which doesn't preserve permissions. That means that if you have an executable file in one `TaskRun` pod and copy it to another `TaskRun` pod via an artifact storage bucket, it won't be executable when it gets there. So let's fix that. fixes tektoncd#1047 Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
9e49d0c to
c9f3631
Compare
|
/test pull-tekton-pipeline-unit-tests |
|
/test tekton-pipeline-unit-tests |
|
@abayer do we have flaky unit tests ? 🤔 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vdemeester yup - #1049 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We're not preserving permissions when copying between tasks, and we should. =)
fixes #1047
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes