-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing substitution of propagated workspace in WorkingDirs #8008
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
8 tasks
tekton-robot
pushed a commit
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes #8008.
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
tekton-robot
pushed a commit
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes #8008.
tekton-robot
pushed a commit
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes #8008.
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this issue
Jun 4, 2024
Fix: Identify workspace usage in a Task Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
tekton-robot
pushed a commit
that referenced
this issue
Jun 4, 2024
Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes #8008.
chitrangpatel
added a commit
to chitrangpatel/pipeline
that referenced
this issue
Jun 5, 2024
Manual cherry-pick to avoid conflict with step-params. Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes tektoncd#8008.
tekton-robot
pushed a commit
that referenced
this issue
Jun 5, 2024
Manual cherry-pick to avoid conflict with step-params. Prior to this, when identifying whether a Task used a workspace, we limited the check to command, args and scripts in steps, stepTemplates and sidecars. However, the workspace path could also be used as a param to a StepAction or env cariables in steps and sidecars and also workingDirs. This PR fixes that. Fixes #8008.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
The abovePipelineRun should run well and replace
$(workspaces.default-workspace.path)
with/workspace/default-workspace
in theworkingDir
of the step because of workspace propagation.Actual Behavior
The substitution is not applied and the container fails with the error message that
the workingDir must be an absolute path
. However, the same works in a Taskrun.Steps to Reproduce the Problem
Additional Info
Kubernetes version:
Output of
kubectl version
:Tekton Pipeline version:
Output of
tkn version
orkubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'
The text was updated successfully, but these errors were encountered: