Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for variable interpolation in workspace.configmap.items * (in PipelineRun and TaskRun) #7667

Closed
piyush-garg opened this issue Feb 14, 2024 · 1 comment · Fixed by #7671
Closed

Support for variable interpolation in workspace.configmap.items * (in PipelineRun and TaskRun) #7667

piyush-garg opened this issue Feb 14, 2024 · 1 comment · Fixed by #7671
Assignees
@l-qing
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@piyush-garg
Copy link
Contributor

piyush-garg commented Feb 14, 2024 •
edited
Loading

This is follow up issue of #6384

Currently, we do support workspace provided as

    - name: custom4
      configMap:
        name: $(params.name)-configmap
        items:
          - key: message
            path: my-message.txt

but we do not support workspace provided as

    - name: custom4
      configMap:
        name: $(params.name)-configmap
        items:
          - key: message
            path: $(params.name)-message.txt

This is to add the support for param replacement at items level in workspace
@piyush-garg piyush-garg added the kind/bug Categorizes issue or PR as related to a bug. label Feb 14, 2024
@l-qing
Copy link
Contributor

l-qing commented Feb 15, 2024

/assign l-qing

l-qing added a commit to l-qing/pipeline that referenced this issue Feb 15, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
21e1b05 
…un and TaskRun)

fix tektoncd#7667
@l-qing l-qing mentioned this issue Feb 15, 2024
Merged
8 tasks
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 17, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
b6478cf 
…un and TaskRun)

fix tektoncd#7667
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 17, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
7a8abcd 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 17, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
ca41dc9 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 21, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
c7e512f 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 22, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
c61546f 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 22, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
325e973 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 26, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
273bc7e 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
@afrittoli afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 26, 2024
l-qing added a commit to l-qing/pipeline that referenced this issue Feb 26, 2024
@l-qing
feat: support for variable interpolation in workspace.* (in PipelineR…
42637e1 
…un and TaskRun)

fix tektoncd#7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
tekton-robot pushed a commit that referenced this issue Feb 26, 2024
@l-qing @tekton-robot
feat: support for variable interpolation in workspace.* (in PipelineR…
33365cf 
…un and TaskRun)

fix #7667

Support for variable interpolation in:

* spec.workspaces[].configMap.items[].*
* spec.workspaces[].secret.items[].*
* spec.workspaces[].projected.sources[].configMap.items[].*
* spec.workspaces[].projected.sources[].secret.items[].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l-qing l-qing

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support for variable interpolation in workspace.* (in PipelineRun and TaskRun) l-qing/pipeline
3 participants
@afrittoli @l-qing @piyush-garg