-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent validation for the image
field for Sidecar versus Step
#7437
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
JeromeJu
added a commit
to JeromeJu/pipeline
that referenced
this issue
Nov 30, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing `stepTemplate.image` and `sidecar.image` are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: tektoncd#7437
7 tasks
JeromeJu
added a commit
to JeromeJu/pipeline
that referenced
this issue
Nov 30, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing and are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: tektoncd#7437
tekton-robot
pushed a commit
that referenced
this issue
Nov 30, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing and are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: #7437
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Nov 30, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing and are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: tektoncd#7437
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this issue
Dec 1, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing and are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: tektoncd#7437
tekton-robot
pushed a commit
that referenced
this issue
Dec 4, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing and are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: #7437
tekton-robot
pushed a commit
that referenced
this issue
Dec 4, 2023
This commit fixes the inconsistent validations for Sidecars by adding webhook validations. It previously only validate Sidecar at runtime instead of what's validated for Step at webhook. It also deletes the docString showing and are optional. BUT the labels of these two fields are kept for backwards compatibility purposes. /kind bug fixes: #7437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
Without specific use cases(i.e. a ref is used in Step for referencing StepAction), users shall assume that Sidecars and Steps undergo identical validation processes.
Actual Behavior
For Step validation:
While for Sidecar it can only be observed via taskRun status:
There are two questions:
Steps to Reproduce the Problem
Apply the following yaml with the image field of sidecar and step commented out one at a time.
Additional Info
devel
Client version: 0.33.0
Pipeline version: v0.54.0
The text was updated successfully, but these errors were encountered: