Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolvers: bundle] Cache resolved bundle to not fetch it all the time #6385

Open
vdemeester opened this issue Mar 17, 2023 · 5 comments
Open
Labels
area/resolution Issues related to remote resolution area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@vdemeester
Copy link
Member

vdemeester commented Mar 17, 2023

Feature request

Provide an option, on the bundle resolver, to be able to cache/store the resolved bundle in order to not have to fetch it each time.

  • If the bundle is identified by the digest, we can cache it directly.
  • If the bundle is identified by a Tag, we could query the registry if the digest we stored for this bundle is still the one targeted by the tag — if not, we re-fetch the bundle, if yes, we just use the cache.
  • This could be optional.
  • We would need to make the "storage" extensible (aka in emptydir, in PVC, in CSI, in s3, …)

Use case

  • Reduce the number of "pull" from registries. For a PipelineRun with 10 tasks, all using the same bundle, I think we pull the bundle 10 times.
  • Reduce the possible impact of service outage / flakyness. If a registry is having an outage or is flaky, as long as the bundle is already in the cache, Pipelines and Tasks wouldn't be affected.
@vdemeester vdemeester added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 17, 2023
@vdemeester
Copy link
Member Author

cc @abayer

@vdemeester
Copy link
Member Author

Slightly related to #6385 as well 👼🏼

@liangyuanpeng
Copy link

liangyuanpeng commented Apr 7, 2023

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2023
@vdemeester
Copy link
Member Author

/lifecycle frozen
/area roadmap

@tekton-robot tekton-robot added area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 6, 2023
@lbernick lbernick added the area/resolution Issues related to remote resolution label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/resolution Issues related to remote resolution area/roadmap Issues that are part of the project (or organization) roadmap (usually an epic) kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

4 participants