-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate release Pipeline to use API-based git remote resolution #6091
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Comments
Part 1: tektoncd/plumbing#1333 |
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this issue
Feb 2, 2023
fixes tektoncd#6091 (this can be merged before tektoncd/plumbing#1333, but it'd definitely be beter for that Plumbing PR to merge first) This switches how we resolve the `publish-release` `Task` in `release-pipeline` from an anonymous git clone to using the GitHub API. The full clone approach is almost always timing out, in part thanks to tektoncd#6025, but even if it finished successfully every time, it'd still be adding at least a minute of extra time to the pipeline execution for no particularly good reason. Using the GitHub API-based resolution instead means no clone is needed, with the resolver just making a couple very specific API calls to get the contents of the specified file. So yeah, much faster! Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
7 tasks
/kind cleanup |
tekton-robot
pushed a commit
that referenced
this issue
Feb 3, 2023
fixes #6091 (this can be merged before tektoncd/plumbing#1333, but it'd definitely be beter for that Plumbing PR to merge first) This switches how we resolve the `publish-release` `Task` in `release-pipeline` from an anonymous git clone to using the GitHub API. The full clone approach is almost always timing out, in part thanks to #6025, but even if it finished successfully every time, it'd still be adding at least a minute of extra time to the pipeline execution for no particularly good reason. Using the GitHub API-based resolution instead means no clone is needed, with the resolver just making a couple very specific API calls to get the contents of the specified file. So yeah, much faster! Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
JeromeJu
pushed a commit
to JeromeJu/pipeline
that referenced
this issue
Feb 6, 2023
fixes tektoncd#6091 (this can be merged before tektoncd/plumbing#1333, but it'd definitely be beter for that Plumbing PR to merge first) This switches how we resolve the `publish-release` `Task` in `release-pipeline` from an anonymous git clone to using the GitHub API. The full clone approach is almost always timing out, in part thanks to tektoncd#6025, but even if it finished successfully every time, it'd still be adding at least a minute of extra time to the pipeline execution for no particularly good reason. Using the GitHub API-based resolution instead means no clone is needed, with the resolver just making a couple very specific API calls to get the contents of the specified file. So yeah, much faster! Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Our current release pipeline uses anonymous git resolution to fetch the publish-images task, which clones the entire pipelines repo. This can cause the remote resolvers controller to be OOMkilled or resolution to time out. We should switch it to use API-based git resolution, which doesn't clone the entire repo.
The text was updated successfully, but these errors were encountered: