Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about upcoming removal of git outputs #1283

Closed
bobcatfish opened this issue Sep 6, 2019 · 2 comments
Closed

Warn about upcoming removal of git outputs #1283

bobcatfish opened this issue Sep 6, 2019 · 2 comments
Labels
area/release Indicates an issue on release (process, tasks).

Comments

@bobcatfish
Copy link
Collaborator

In #1109 we will remove support for git outputs. We may add support via #1280 in the same release but even if we do, the functionality of a git output will be radically different from what it is today. We should include a warning in 1 release, via both release notes and via a warning logged by the controller whenever git is used as an output.

@bobcatfish bobcatfish added this to the Pipelines 0.7 🐱 milestone Sep 6, 2019
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Sep 14, 2019
In tektoncd#1109 we will be removing support for git as an output. In the
current implementation, git as an output is just a volume that holds the
data from the git repo, and copies it between Tasks (when git as an
output is linked to git as an input). As discussed in tektoncd#1076, the model
we want for PipelineResources is for them to take the outside world and
represent it on disk when used as an input, and when used as an output,
to update the outside world. In order to do this, what we actually want for a
git output is for it to create a commit the repo it is referencing.
However up until this point folks have been using git resources in the
way that we want Volume Resources to behave tektoncd#1062, so we want to
transition folks to Volume Resources and away from using git outputs.

Fixes tektoncd#1283
@bobcatfish bobcatfish removed this from the Pipelines 0.8 🐱 milestone Oct 3, 2019
@vdemeester
Copy link
Member

@bobcatfish @dlorenc what is the status for this one ?

/kind api
/area release

@tekton-robot tekton-robot added the area/release Indicates an issue on release (process, tasks). label Dec 9, 2019
@bobcatfish
Copy link
Collaborator Author

Looks like the warning was added in #1310 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Indicates an issue on release (process, tasks).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants