Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we run imageDigestExporter after each step in a taskrun? #1104

Closed
dibyom opened this issue Jul 18, 2019 · 3 comments · Fixed by #1126
Closed

Why do we run imageDigestExporter after each step in a taskrun? #1104

dibyom opened this issue Jul 18, 2019 · 3 comments · Fixed by #1126
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@dibyom
Copy link
Member

dibyom commented Jul 18, 2019

The imageDigestExporter container writes the digest of any built images to the container's terminationMessagePath which is then parsed by the taskrun controller in order to update the taskrun's status with the image digests.

The container only gets added if a task contains an output resource of type image. However, it gets added after each step as opposed to being added just once (after all the regular steps). The container itself takes as input all the output images that will be produced in a task, and writes the digest for all of them. So, it is unclear to me why we need to run it after each step.

Does anyone know why we need to run the container after each step? Maybe @nader-ziada or @imjasonh ?

/kind question

@tekton-robot tekton-robot added the kind/question Issues or PRs that are questions around the project or a particular feature label Jul 18, 2019
@vdemeester
Copy link
Member

vdemeester commented Jul 25, 2019

Looking into that, I think this is working like that to support multiple image built in different steps. but looking at the code, only one step/container is needed.

/assign
/kind bug
/remove-kind question

@tekton-robot
Copy link
Collaborator

@vdemeester: Those labels are not set on the issue: kind/bug

In response to this:

Looking into that, I think this is working like that to support multiple image built in different steps. but looking at the code, only one step/container is needed.

/assign
/kind bug
/remove-kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 25, 2019
@vdemeester vdemeester removed the kind/question Issues or PRs that are questions around the project or a particular feature label Jul 25, 2019
@tekton-robot
Copy link
Collaborator

@vdemeester: Those labels are not set on the issue: kind/question

In response to this:

Looking into that, I think this is working like that to support multiple image built in different steps. but looking at the code, only one step/container is needed.

/assign
/kind bug
/remove-kind question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants