Skip to content

Commit

Permalink
Rename test cases for beta feature validations
Browse files Browse the repository at this point in the history
This commit renames the test cases for beta feature validations which
previously had the tests constructed to return an error without the
feature flags being set. This was no longer the case after the refactor
and this commit aims to avoid the confusions.

/kind misc
  • Loading branch information
JeromeJu authored and tekton-robot committed Oct 11, 2023
1 parent d44ba74 commit e0e1073
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions pkg/apis/pipeline/v1/pipeline_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3857,23 +3857,23 @@ func TestPipelineWithBetaFields(t *testing.T) {
}},
},
}, {
name: "pipeline tasks - use of resolver without the feature flag set",
name: "pipeline tasks - use of resolver",
spec: PipelineSpec{
Tasks: []PipelineTask{{
Name: "uses-resolver",
TaskRef: &TaskRef{ResolverRef: ResolverRef{Resolver: "bar"}},
}},
},
}, {
name: "pipeline tasks - use of resolver params without the feature flag set",
name: "pipeline tasks - use of resolver params",
spec: PipelineSpec{
Tasks: []PipelineTask{{
Name: "uses-resolver-params",
TaskRef: &TaskRef{ResolverRef: ResolverRef{Resolver: "bar", Params: Params{{}}}},
}},
},
}, {
name: "finally tasks - use of resolver without the feature flag set",
name: "finally tasks - use of resolver",
spec: PipelineSpec{
Tasks: []PipelineTask{{
Name: "valid-pipeline-task",
Expand All @@ -3885,7 +3885,7 @@ func TestPipelineWithBetaFields(t *testing.T) {
}},
},
}, {
name: "finally tasks - use of resolver params without the feature flag set",
name: "finally tasks - use of resolver params",
spec: PipelineSpec{
Tasks: []PipelineTask{{
Name: "valid-pipeline-task",
Expand Down
8 changes: 4 additions & 4 deletions pkg/apis/pipeline/v1/pipelinerun_validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1447,23 +1447,23 @@ func TestPipelineRunSpecBetaFeatures(t *testing.T) {
}},
},
}, {
name: "pipeline tasks - use of resolver without the feature flag set",
name: "pipeline tasks - use of resolver",
spec: v1.PipelineSpec{
Tasks: []v1.PipelineTask{{
Name: "uses-resolver",
TaskRef: &v1.TaskRef{ResolverRef: v1.ResolverRef{Resolver: "bar"}},
}},
},
}, {
name: "pipeline tasks - use of resolver params without the feature flag set",
name: "pipeline tasks - use of resolver params",
spec: v1.PipelineSpec{
Tasks: []v1.PipelineTask{{
Name: "uses-resolver-params",
TaskRef: &v1.TaskRef{ResolverRef: v1.ResolverRef{Resolver: "bar", Params: v1.Params{{}}}},
}},
},
}, {
name: "finally tasks - use of resolver without the feature flag set",
name: "finally tasks - use of resolver",
spec: v1.PipelineSpec{
Tasks: []v1.PipelineTask{{
Name: "valid-pipeline-task",
Expand All @@ -1475,7 +1475,7 @@ func TestPipelineRunSpecBetaFeatures(t *testing.T) {
}},
},
}, {
name: "finally tasks - use of resolver params without the feature flag set",
name: "finally tasks - use of resolver params",
spec: v1.PipelineSpec{
Tasks: []v1.PipelineTask{{
Name: "valid-pipeline-task",
Expand Down

0 comments on commit e0e1073

Please sign in to comment.