Skip to content

Commit

Permalink
Use ko:// in e2e tests to exercices current code 🙃
Browse files Browse the repository at this point in the history
Right now, some examples are exercicing old version of the code, and
definitely never the changes that would be on the images in a PR.
Using `ko://` instead helps with that (e2e tests are using `ko` to
apply the samples).

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
  • Loading branch information
vdemeester committed Jul 7, 2020
1 parent 4bdeaa3 commit c62e278
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ spec:
description: The precise commit SHA that was fetched by this Task
steps:
- name: clone
image: gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.12.1
image: ko://github.com/tektoncd/pipeline/cmd/git-init
script: |
#!/bin/ash
CHECKOUT_DIR="$(workspaces.output.path)/$(params.subdirectory)"
cleandir() {
Expand Down
5 changes: 3 additions & 2 deletions examples/v1beta1/pipelineruns/pipelinerun.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ spec:
description: The precise commit SHA that was fetched by this Task
steps:
- name: clone
image: gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/git-init:v0.11.0
image: ko://github.com/tektoncd/pipeline/cmd/git-init
script: |
#!/bin/ash
CHECKOUT_DIR="$(workspaces.output.path)/$(params.subdirectory)"
cleandir() {
# Delete any existing contents of the repo directory if it exists.
Expand Down Expand Up @@ -167,7 +168,7 @@ spec:
runAsUser: 0
- name: write-digest
workingDir: $(workspaces.source.path)
image: gcr.io/tekton-releases/github.com/tektoncd/pipeline/cmd/imagedigestexporter:v0.11.1
image: ko://github.com/tektoncd/pipeline/cmd/imagedigestexporter
# output of imagedigestexport [{"name":"image","digest":"sha256:eed29..660"}]
command: ["/ko-app/imagedigestexporter"]
args:
Expand Down

0 comments on commit c62e278

Please sign in to comment.