pkg/apis: unexport ApplyContainerReplacements

It is only used internally. This also removes the
`container_replacements_test.go` as the code is/should already be
covered by `sidecar_replacements_test.go` and
`step_replacements_test.go`.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>

pkg/apis/pipeline/v1beta1/container_replacements.go

@@ -21,7 +21,8 @@ import (
 	corev1 "k8s.io/api/core/v1"
 )
 
-func ApplyContainerReplacements(step *corev1.Container, stringReplacements map[string]string, arrayReplacements map[string][]string) {
+// applyContainerReplacements applies variable interpolation on a Container (subset of a Step).
+func applyContainerReplacements(step *corev1.Container, stringReplacements map[string]string, arrayReplacements map[string][]string) {
 	step.Name = substitution.ApplyReplacements(step.Name, stringReplacements)
 	step.Image = substitution.ApplyReplacements(step.Image, stringReplacements)
 	step.ImagePullPolicy = corev1.PullPolicy(substitution.ApplyReplacements(string(step.ImagePullPolicy), stringReplacements))

pkg/apis/pipeline/v1beta1/sidecar_replacements.go

@@ -20,7 +20,8 @@ import (
 	"github.com/tektoncd/pipeline/pkg/substitution"
 )
 
+// ApplySidecarReplacements applies variable interpolation on a Sidecar.
 func ApplySidecarReplacements(sidecar *Sidecar, stringReplacements map[string]string, arrayReplacements map[string][]string) {
 	sidecar.Script = substitution.ApplyReplacements(sidecar.Script, stringReplacements)
-	ApplyContainerReplacements(&sidecar.Container, stringReplacements, arrayReplacements)
+	applyContainerReplacements(&sidecar.Container, stringReplacements, arrayReplacements)
 }

pkg/apis/pipeline/v1beta1/step_replacements.go

@@ -20,7 +20,8 @@ import (
 	"github.com/tektoncd/pipeline/pkg/substitution"
 )
 
+// ApplyStepReplacements applies variable interpolation on a Step.
 func ApplyStepReplacements(step *Step, stringReplacements map[string]string, arrayReplacements map[string][]string) {
 	step.Script = substitution.ApplyReplacements(step.Script, stringReplacements)
-	ApplyContainerReplacements(&step.Container, stringReplacements, arrayReplacements)
+	applyContainerReplacements(&step.Container, stringReplacements, arrayReplacements)
 }