Propagated Parameters for Finally Tasks

Propagated parameters was only called for regular pipeline tasks, not finally tasks.
This was due to an oversight, and not a design choice. This PR extends
the propagated paramsters usage to finally tasks now. It addresses
issue #5588 .

examples/v1beta1/pipelineruns/alpha/propagating_params_implicit_parameters.yaml

@@ -16,3 +16,12 @@ spec:
               script: |
                 #!/usr/bin/env bash
                 echo "$(params.HELLO)"
+    finally:
+      - name: echo-hello-finally
+        taskSpec:
+          steps:
+            - name: echo
+              image: ubuntu
+              script: |
+                #!/usr/bin/env bash
+                echo "And Finally ... $(params.HELLO)"

examples/v1beta1/pipelineruns/alpha/propagating_params_with_scope_precedence.yaml

@@ -19,3 +19,15 @@ spec:
               script: |
                 #!/usr/bin/env bash
                 echo "$(params.HELLO)"
+    finally:
+      - name: echo-hello-finally
+        params:
+          - name: HELLO
+            value: "Finally Hello World!"
+        taskSpec:
+          steps:
+            - name: echo
+              image: ubuntu
+              script: |
+                #!/usr/bin/env bash
+                echo "And finally.. $(params.HELLO)"

examples/v1beta1/pipelineruns/alpha/propagating_params_with_scope_precedence_default_only.yaml

@@ -19,3 +19,15 @@ spec:
               script: |
                 #!/usr/bin/env bash
                 echo "$(params.HELLO)"
+    finally:
+      - name: echo-hello-finally
+        taskSpec:
+          params:
+            - name: HELLO
+              default: "Default Hello World!"
+          steps:
+            - name: echo
+              image: ubuntu
+              script: |
+                #!/usr/bin/env bash
+                echo "And finally... $(params.HELLO)"

pkg/reconciler/pipelinerun/resources/apply.go

@@ -249,6 +249,7 @@ func ApplyReplacements(ctx context.Context, p *v1beta1.PipelineSpec, replacement
 		if p.Finally[i].TaskRef != nil && p.Finally[i].TaskRef.Params != nil {
 			p.Finally[i].TaskRef.Params = replaceParamValues(p.Finally[i].TaskRef.Params, replacements, arrayReplacements, objectReplacements)
 		}
+		p.Finally[i], replacements, arrayReplacements, objectReplacements = propagateParams(ctx, p.Finally[i], replacements, arrayReplacements, objectReplacements)
 	}
 
 	return p