[TEP-0137] Rename customrun package to notifications

The pkg/reconciler/customrun package contains a controller that
today sends cloudevents for CustomRuns. In the context of TEP-0137,
this controller will be repurposed to send events for all resources,
so the current name does not make sense anymore.

Renaming the package to "notifications", because the "events" and
"cloudevents" names are already used elsewhere and we don't want
a mass API rename for this. We might consolidate the code further
as a follow-up. The new name is also more future-proof, as the
controller may in future handle other kinds of non-cloudevents
type of notifications.

When renaming I realised that the customrun controller was being
started as part of the main controller as well as an independent
one. This PR fixes that bug as well.

Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>

cmd/controller/main.go

@@ -26,7 +26,6 @@ import (
 
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
-	"github.com/tektoncd/pipeline/pkg/reconciler/customrun"
 	"github.com/tektoncd/pipeline/pkg/reconciler/pipelinerun"
 	"github.com/tektoncd/pipeline/pkg/reconciler/resolutionrequest"
 	"github.com/tektoncd/pipeline/pkg/reconciler/taskrun"
@@ -131,7 +130,6 @@ func main() {
 		taskrun.NewController(opts, clock.RealClock{}, tpTaskrun),
 		pipelinerun.NewController(opts, clock.RealClock{}, tpPipelineRun),
 		resolutionrequest.NewController(clock.RealClock{}),
-		customrun.NewController(),
 	)
 
 	// Cleanly shutdown and flush telemetry when the application exits.

cmd/events/main.go

@@ -21,7 +21,7 @@ import (
 	"net/http"
 	"os"
 
-	"github.com/tektoncd/pipeline/pkg/reconciler/customrun"
+	"github.com/tektoncd/pipeline/pkg/reconciler/notifications"
 	"knative.dev/pkg/injection/sharedmain"
 )
 
@@ -47,7 +47,7 @@ func main() {
 	}()
 
 	// start the events controller
-	sharedmain.Main(eventsControllerName, customrun.NewController())
+	sharedmain.Main(eventsControllerName, notifications.NewController())
 }
 
 func handler(w http.ResponseWriter, r *http.Request) {

pkg/reconciler/customrun/controller.go → pkg/reconciler/notifications/controller.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package customrun
+package notifications
 
 import (
 	"context"

pkg/reconciler/customrun/customrun.go → pkg/reconciler/notifications/notifications.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package customrun
+package notifications
 
 import (
 	"context"

pkg/reconciler/customrun/customrun_test.go → pkg/reconciler/notifications/notifications_test.go

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-package customrun_test
+package notifications_test
 
 import (
 	"context"
@@ -25,8 +25,8 @@ import (
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/tektoncd/pipeline/pkg/apis/config"
 	"github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1"
-	customrun "github.com/tektoncd/pipeline/pkg/reconciler/customrun"
 	"github.com/tektoncd/pipeline/pkg/reconciler/events/cloudevent"
+	"github.com/tektoncd/pipeline/pkg/reconciler/notifications"
 	ttesting "github.com/tektoncd/pipeline/pkg/reconciler/testing"
 	"github.com/tektoncd/pipeline/test"
 	"github.com/tektoncd/pipeline/test/names"
@@ -52,7 +52,7 @@ func initializeCustomRunControllerAssets(t *testing.T, d test.Data) (test.Assets
 	test.EnsureConfigurationConfigMapsExist(&d)
 	c, informers := test.SeedTestData(t, ctx, d)
 	configMapWatcher := cminformer.NewInformedWatcher(c.Kube, system.Namespace())
-	ctl := customrun.NewController()(ctx, configMapWatcher)
+	ctl := notifications.NewController()(ctx, configMapWatcher)
 	if err := configMapWatcher.Start(ctx.Done()); err != nil {
 		t.Fatalf("error starting configmap watcher: %v", err)
 	}