Skip to content

Commit

Permalink
Make sure that OpenAPI rules violations errors show up in Prow build …
Browse files Browse the repository at this point in the history
…logs

I noticed recently that `pull-tekton-pipeline-build-tests` will properly fail for a new OpenAPI rules violation, but the failure doesn't get shown on the Prow page for the job unless you expand to see the full log. This is because the error message doesn't contain any of the strings Spyglass/Prow are searching for in the logs to identify errors/failures. So let's add `ERROR:` to the message.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
  • Loading branch information
abayer authored and tekton-robot committed Aug 1, 2022
1 parent 88fbc86 commit 860b628
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions hack/update-openapigen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ do
violations=$(diff --changed-group-format='%>' --unchanged-group-format='' <(sort "hack/ignored-openapi-violations.list") <(sort "${TMP_DIFFROOT}/api-report") || echo "")
if [ -n "${violations}" ]; then
echo ""
echo "New API rule violations found which are not present in hack/ignored-openapi-violations.list. Please fix these violations:"
echo "ERROR: New API rule violations found which are not present in hack/ignored-openapi-violations.list. Please fix these violations:"
echo ""
echo "${violations}"
echo ""
Expand All @@ -61,4 +61,4 @@ do

echo "Generating swagger file for ${APIVERSION} ..."
go run hack/spec-gen/main.go -apiVersion=${APIVERSION} > pkg/apis/pipeline/${APIVERSION}/swagger.json
done
done

0 comments on commit 860b628

Please sign in to comment.