TEP-0118: Update Pipeline Conversion for Matrix Include Parameters

This commit updates Pipeline Conversion to convert Matrix Include Parameters

Note: This feature is still in preview mode.

pkg/apis/pipeline/v1beta1/pipeline_conversion.go

@@ -259,6 +259,14 @@ func (m *Matrix) convertTo(ctx context.Context, sink *v1.Matrix) {
 		param.convertTo(ctx, &new)
 		sink.Params = append(sink.Params, new)
 	}
+	for i, include := range m.Include {
+		sink.Include = append(sink.Include, v1.MatrixInclude{Name: include.Name})
+		for _, param := range include.Params {
+			newIncludeParam := v1.Param{}
+			param.convertTo(ctx, &newIncludeParam)
+			sink.Include[i].Params = append(sink.Include[i].Params, newIncludeParam)
+		}
+	}
 }
 
 func (m *Matrix) convertFrom(ctx context.Context, source v1.Matrix) {
@@ -267,6 +275,15 @@ func (m *Matrix) convertFrom(ctx context.Context, source v1.Matrix) {
 		new.convertFrom(ctx, param)
 		m.Params = append(m.Params, new)
 	}
+
+	for i, include := range source.Include {
+		m.Include = append(m.Include, MatrixInclude{Name: include.Name})
+		for _, p := range include.Params {
+			new := Param{}
+			new.convertFrom(ctx, p)
+			m.Include[i].Params = append(m.Include[i].Params, new)
+		}
+	}
 }
 
 func (pr PipelineResult) convertTo(ctx context.Context, sink *v1.PipelineResult) {

pkg/apis/pipeline/v1beta1/pipeline_conversion_test.go

@@ -108,13 +108,21 @@ func TestPipelineConversion(t *testing.T) {
 						},
 					}},
 					Matrix: &v1beta1.Matrix{
-						Params: []v1beta1.Param{{
+						Params: v1beta1.Params{{
 							Name: "a-param",
 							Value: v1beta1.ParamValue{
 								Type:     v1beta1.ParamTypeArray,
 								ArrayVal: []string{"$(params.baz)", "and", "$(params.foo-is-baz)"},
 							},
-						}}},
+						}},
+						Include: []v1beta1.MatrixInclude{{
+							Name: "baz",
+							Params: v1beta1.Params{{
+								Name: "a-param", Value: v1beta1.ParamValue{Type: v1beta1.ParamTypeString, StringVal: "$(params.baz)"},
+							}, {
+								Name: "flags", Value: v1beta1.ParamValue{Type: v1beta1.ParamTypeString, StringVal: "-cover -v"}}},
+						}},
+					},
 					Workspaces: []v1beta1.WorkspacePipelineTaskBinding{{
 						Name:      "my-task-workspace",
 						Workspace: "source",