Skip to content

Commit

Permalink
Add comment linking configmap names in deployments to names in role
Browse files Browse the repository at this point in the history
If a user wants to change the names of the configmaps that Tekton's
controller and webhook use then they'll also need to update the
Roles associated with those deployments. The Roles explicitly name
the ConfigMaps that these deployments can access.

This PR just adds a comment to help remind people that if they're
changing the ConfigMap names they'll need to also update the Roles.
  • Loading branch information
Scott authored and tekton-robot committed Apr 16, 2020
1 parent 6c4f6b0 commit 7cb3f48
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions config/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
# If you are changing these names, you will also need to update
# the controller's Role in 200-role.yaml to include the new
# values in the "configmaps" "get" rule.
- name: CONFIG_LOGGING_NAME
value: config-logging
- name: CONFIG_OBSERVABILITY_NAME
Expand Down
3 changes: 3 additions & 0 deletions config/webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
# If you are changing these names, you will also need to update
# the webhook's Role in 200-role.yaml to include the new
# values in the "configmaps" "get" rule.
- name: CONFIG_LOGGING_NAME
value: config-logging
- name: CONFIG_OBSERVABILITY_NAME
Expand Down

0 comments on commit 7cb3f48

Please sign in to comment.